Youtube Embeds not working with SSL

Gillingham

Recently converted my forum to run entirely on SSL since right now vanilla doesn't really have a way for me to enforce it on just the login.

The issue here is now youtube embeds don't work. Empty white space appears where the video should be displayed, but nothing actually shows up.

Gillingham

Investigating it looks to be an issue with library/core/class.format.php

<div class="Video"><object width="$Width" height="$Height"><param name="movie" value="http://www.youtube.com/v/$ID&amp;hl=en_US&amp;fs=1&amp;"></param><param name="allowFullScreen" value="true"></param><param name="allowscriptaccess" value="always"></param><embed src="http://www.youtube.com/v/$ID&amp;hl=en_US&amp;fs=1&amp;" type="application/x-shockwave-flash" allowscriptaccess="always" allowfullscreen="true" width="$Width" height="$Height"></embed></object></div>

I just changed the http:// links to https:// manually but I guess vanilla should be smart enough to check if the request is over https and use https instead of http.

edit Markdown sucks when the code contains backticks, actually so does this block styling.

Tama

@Gillingham I believe in 2.2(or .1) the embed format has been changed to use scheme less urls for embeding external media.

vrijvlinder

@Gillingham Use Mediator Plugin to embed it supports https links too .

http://vanillaforums.org/addon/mediator-plugin

Gillingham

@Tama said:
Gillingham I believe in 2.2(or .1) the embed format has been changed to use scheme less urls for embeding external media.

Looking at https://github.com/vanillaforums/Garden/blob/2.1/library/core/class.format.php it has not been fixed, same in the develop branch. Guess I'll open an issue on github

Shadowdare

It's in the 2.2 master branch. https://github.com/vanillaforums/Garden/commit/2899eb511e78ba58a9cdb6c7c98281d8772f498b