i can't type character in tags!

Client

i enabled (Tagging) plugin.
but i can't type this key "," in tags.
the problem is this key "," in arabic is "و" and this a character, so i can't type "و" in tags
how i can fix this?

Client

any help?

Bleistivt

In the admin screen where you add tags or when you post a discussion?

Client

@Bleistivt said:
In the admin screen where you add tags or when you post a discussion?

when i post a discussion.
i can't use this key "," but in arabic.

Bleistivt

Commas are not allowed in tags, but I created a tag with "و" and was able to successfully add it to a discussion.

When you type in و into the tag textfield, does it not appear in the auto-suggest menu?

Client

@Bleistivt
i talking about comma key that in english but when i change keyboard language to arabic
comma turns into the letter "و" in arabic
so i need to allowed this key.. to type "و"

Bleistivt

So what appears in the textfield? , or و ?

Client

@Bleistivt said:

So what appears in the textfield? , or و ?

in tags textfield no thing appear, both!

Client

but i can paste letter و or ,
now i want to allow that key

Bleistivt

Commas can't be typed, because they separate tags from each other.

I don't know how arabic keyboard input works, but I guess you have to press "," for the "و" to appear?

That is unfortunately how the token input works.

Client

@Bleistivt
ya that's right i have to press "," for the "و" exactly.
i think the problem here "jquery.tokeninput.vanilla.js"
and i'm searching for a solution.

Bleistivt

Yes, the problem is, that there is a setting:

tokenDelimiter: ","

but changing it doesn't work, I already tested it.

The comma key is hardcoded in a lot of places:
https://github.com/vanilla/vanilla/blob/2.1/plugins/Tagging/js/jquery.tokeninput.vanilla.js#L282

Client

@Bleistivt‌
finally! the solution is to delete line (94)

COMMA: 188

Bleistivt

Can you still separate tags from each other and have you made additional modifications?

This would be a good pull request. A definition for the token delimiter could be added, which could be changed via locale.

Client

@Bleistivt said:
Can you still separate tags from each other and have you made additional modifications?

yes i can, when i use comma it's still works to separate tags, currently i'm using Enter key, and i didn't made any additional modifications.
i'm just translate some sentences at js files.

This would be a good pull request. A definition for the token delimiter could be added, which could be changed via locale.

ya its good idea.
thanks.