Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.
Options
QuoteSelection and vanilla 2.0.18
tmilovan
New
Quote selection and Quotes plugins stopped working after upgrade to 2.0.18. After quoting browser is focused on textarea but string is not carried over.
I have managed to catch an js error that shows after unsucessful quoting:
/forum/plugins/QuoteSelection/quoteselection.js:77
or
/forum/plugins/QuoteSelection/quoteselection.js:96 in latest version of plugin.
"TypeError: Result of expression 'quoteData.url' [undefined] is not an object."
I have managed to catch an js error that shows after unsucessful quoting:
/forum/plugins/QuoteSelection/quoteselection.js:77
or
/forum/plugins/QuoteSelection/quoteselection.js:96 in latest version of plugin.
"TypeError: Result of expression 'quoteData.url' [undefined] is not an object."
Tagged:
0
Answers
Problem is in the line 96 of the /plugins/QuoteSelection/quoteselection.js file:
url = quoteData.url.replace(/^https?:\/\/[^\/]*/, '');
return "> [" + title + "](" + url + "): " +
quoteData.text.replace("\r", "").replace(/\n{2,}/gm, "\n\n>") +
"\n\n";
but if we skip domain trimming everything works fine:
//url = quoteData.url.replace(/^https?:\/\/[^\/]*/, '');
return "> [" + title + "](" + quoteData.url + "): " +
quoteData.text.replace("\r", "").replace(/\n{2,}/gm, "\n\n>") +
"\n\n";
I can't get this to work with 2.0.18. Quote button does not appear at all.
-k0nsl