Bug found with class.activitymodel

egonelbre

Backtrace:
[.../vanilla2/library/core/functions.error.php:132] PHP::include();
[.../vanilla2/applications/garden/models/class.activitymodel.php:157] PHP::ErrorHandler();
[.../vanilla2/applications/garden/models/class.activitymodel.php:149] Gdn_ActivityModel->SendNotification();
[.../vanilla2/library/core/functions.general.php:62] Gdn_ActivityModel->Add();
[.../vanilla2/applications/garden/models/class.usermodel.php:485] PHP::AddActivity();
[.../vanilla2/applications/garden/models/class.usermodel.php:1202] Gdn_UserModel->SaveRoles();
[.../vanilla2/library/core/class.handshakeauthenticator.php:186] Gdn_UserModel->Synchronize();
[.../vanilla2/library/core/class.session.php:225] Gdn_HandshakeAuthenticator->GetIdentity();
[.../vanilla2/index.php:30] Gdn_Session->Start();

What happens is:
class.session.php@225
$this->UserID = $Authenticator->GetIdentity();

... then nests inwards until
class.usermodel.php@480
AddActivity(
$Session->UserID,
'RoleChange',
$Story,
$UserID
);

At that point $Session->UserID is 0 and it screws up ActivityQuery because there isn't a user with id=0 to do join with.

egonelbre

Sorry, couldn't find Bug Tracker before.

suicideking

what symptoms are you experiencing with this fault?