Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

TestAddon ProxyRequest Fail

edited May 2010 in Vanilla 2.0 - 2.8
Running the RC, however with the newly implemented TestAddon feature the ProxyRequest function on my localhost.
The right Url is being passed to the function however i assume due to the way it splits it it tries to request


On closer inspection it appears its the way the url is setup for cURL it ignores the Port in the request. It works fine using the file_get_contents which does use the Port value.

Not sure why the cURL part doesn't just use the $Url param in the first place. Commenting out line 811 of functions.general.php works a treat.


  • Options
    TimTim Operations Vanilla Staff
    This method is being reworked and will rely on AJAX now, instead of sockets and cURL. Should see a fix shortly.

    Vanilla Forums COO [GitHub, Twitter,]

  • Options
    I thought Vanilla 2 was non javascript user friendly too?
  • Options
    TimTim Operations Vanilla Staff
    You are correct of course. When I say 'rely', I mean that it will attempt to use AJAX and gracefully degrade if it cannot.

    My personal opinion is that we should try to use AJAX first. If it fails, try cURL / fsockopen. If those fail then fall back to blindly enabling the addon and letting the admin deal with whatever carnage he may unleash.

    Vanilla Forums COO [GitHub, Twitter,]

  • Options
    @Tim Ah okay, it was just the "rely on" that had me :)
Sign In or Register to comment.