Blog Documentation Book a Demo
Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

Signature

garymardellgarymardell ✭
edited May 2010 in Vanilla 2.0 - 2.8
Signature

Comments

  • GumCloudGumCloud New
    Works fine! Thank you!
  • oinkfuoinkfu
    Hmm works fine up until it needs to be displayed on the posts, then you get an error (latest version of V2, rc1)...
  • garymardellgarymardell ✭
    @oinkfu I will try and fix for the RC now, as its been released now :)
  • becoolbecool
    @garymardell Have you got around to fixing this yet?

    Thanks
  • lucluc ✭✭
    Not sure if it's really worth fixing. Since RC1 was released, many many commits were done.
  • garymardellgarymardell ✭
    @becool It should now work.

    @luc It wasn't too bad to fix, although i think before all the comments included the post itself counted as comments, now the post is a discussion. So i have to get the signature in both models.
  • becoolbecool
    Thanks!
  • garymardellgarymardell ✭
    @becool There is one more thing sorry, you will need to update to address a security concern. The output of a signature is now formatted with the htmlpurifier to prevent malicious javascript in signature for example. I urge you to upgrade or change line 36 of defaul.php to

    <?php echo Gdn_Format::Html($Comment->Signature); ?>
  • becoolbecool
    thanks will do!
Sign In or Register to comment.