Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.
Addon unapproved: ereg is deprecated
Mark
Vanilla Staff
I've unapproved this addon.
I was doing some testing on this addon after some changes to our codebase, and I noticed that the author is using ereg, which is a deprecated php function. You will need to update the plugin to use preg_match instead of ereg on line 25.
I also noticed that there is a bug in DiscussionController_BeforeCommentBody_Handler. The first comment in a discussion actually comes from the discussion data rather than the comment list. You will need to account for this when grabbing the first comment's body. Here's a fix:
I was doing some testing on this addon after some changes to our codebase, and I noticed that the author is using ereg, which is a deprecated php function. You will need to update the plugin to use preg_match instead of ereg on line 25.
I also noticed that there is a bug in DiscussionController_BeforeCommentBody_Handler. The first comment in a discussion actually comes from the discussion data rather than the comment list. You will need to account for this when grabbing the first comment's body. Here's a fix:
public function DiscussionController_BeforeCommentBody_Handler(&$Sender) {
$Object = array_key_exists('Comment', $Sender->EventArguments) ? 'Comment' : 'Discussion';
$Sender->EventArguments[$Object]->Body = $this->MakeView($Sender->EventArguments[$Object]->Body);
}
Tagged:
1