Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

Improvement for HTML mode

npnp
edited January 2011 in Vanilla 2.0 - 2.8
Quotes 1.2

In HTML mode, the quoted text has code
Like this
This doesn't show the user name, and I believe is a misuse of the rel tag. Here's a patch it to make it the style that Quote selection uses:
username said: Like this
diff -r Quotes/class.quotes.plugin.php Quotesmod/class.quotes.plugin.php
140c140
<                   $Sender->Form->SetValue('Body', '<blockquote rel="'.$QuoteData['authorname'].'">'.$QuoteData['body']."</blockquote>\n");
---
>                   $Sender->Form->SetValue('Body', '<blockquote><a href="'.$QuoteData['url'].'">'.$QuoteData['authorname'].' said</a>: '.$QuoteData['body']."</blockquote>\n");
179c179,180
<             'authorname'   => $Data->InsertName
---
>             'authorname'   => $Data->InsertName,
>             'url'          => Gdn::Request()->Url('/discussion/comment/'.$Data->CommentID.'/#Comment_'.$Data->CommentID, false, false)
diff -r Quotes/js/quotes.js Quotesmod/js/quotes.js
208c208
<             var Append = '<blockquote rel="'+Data.Quote.authorname+'">'+Data.Quote.body+'</blockquote>'+"\n";
---
>             var Append = '<blockquote><a href="'+Data.Quote.url+'">'+Data.Quote.authorname+' said</a>: '+Data.Quote.body+'</blockquote>'+"\n";
Tagged:

Comments

  • Hmm, the first case works on this forum. It doesn't work on my forum. It just shows the text without the user's name or any styling.
Sign In or Register to comment.