Deleting a discussion ends in a 404

TobyLeftly

Hi there

My vanilla forum appears to be working perfectly, except for one strange glitch - when I delete a discussion, the discussion disappears (as expected) but then the page redirects to what looks like it should be the discussions list, but the URL is wrong so the page 404s.

the URL used is:

mysite.com/vanilla/discussions/

when the regular discussions page exists at:

mysite.com/forums/discussions/

Does anyone know where to change this one incorrect variable?

Thanks!

camstudio

Yep, I'm having the same problem as well.

Anyone shed any light on this?

Homebrew_Korea

I just had it as well.

luc

Deleting it from the discussion from the list of discussions or within one?

I think I saw some fixes for that go into the unstable branch.

yu_tang

/applications/vanilla/controllers/class.discussioncontroller.php

Search Delete() function.

Replace:

      // Redirect
      if ($this->_DeliveryType === DELIVERY_TYPE_ALL)
         Redirect(GetIncomingValue('Target', '/vanilla/discussions'));

      if ($this->Form->ErrorCount() > 0)
         $this->SetJson('ErrorMessage', $this->Form->Errors());

      $this->RedirectUrl = GetIncomingValue('Target', '/vanilla/discussions');
      $this->Render();

with:

      // Redirect
$DefaultController = Gdn::Router()->GetRoute('DefaultController');
$DefaultTarget = Gdn_Url::WebRoot(TRUE).'/'.$DefaultController['Destination'];

      if ($this->_DeliveryType === DELIVERY_TYPE_ALL)
         Redirect(GetIncomingValue('Target', $DefaultTarget));

      if ($this->Form->ErrorCount() > 0)
         $this->SetJson('ErrorMessage', $this->Form->Errors());

      $this->RedirectUrl = GetIncomingValue('Target', $DefaultTarget);
      $this->Render();

I don't like a core hack and an upgrading nightmare.
Hope fix coming in next release.

I think I saw some fixes for that go into the unstable branch.

Can you please point me out in which commit of the unstable branch?
Try to find and seems to be lost.
Thanks in advance.

luc

@yu_tang: I guess I imagined it, or I saw some fix in the forum instead of the rss feed of the commits.
I had a look at all the commits comments up to end of January and nothing seemed to be fixing this.

yu_tang

@luc
Oh, I got it. Thanks for your time. :-)

camstudio

@yu_tang I tried your fix and got redirected to this URL:

http://camstudio.org/forum/categories/categories/moderators-only

There's one "categories" too many ...

Cheers

Nick )

yu_tang

@camstudio
Thanks for your feedback.
You can simply replace '/vanilla/discussions' with your url.
It's just a temporary solution, but I think it is enough for now unless you change vanilla directory everyday.

chadvonnau

@yu_tang thank you

camstudio

@yu_tang

Sorry, only just got back to this topic ... do you mean in the original code I should just replace '/vanilla/discussions' with '/forum/discussions' ??

Cheers

Nick )

yu_tang

@camstudio
Yes, you got it.

Btw, have you tested this issue with 2.0.18?

EugenioR

I had the same problem. Version 2.0.17.10, embedded in an iframe; replacing with "/forum/discussions" didn't work. I had to replace (three instances of)

"/vanilla/discussions"

with

"/forum/index.php?p=/discussions"

Maybe this can help someone else, maybe I'm pointing an obvious thing... btw, this fixed the problem. Thanks.

w32u64

My solution, I created an index.php *, in vanilla / discussions (/index.php *), and a rerouting towards the page of home

It allows not to touch the code of origin

jspautsch

@EugenioR 's solution should work, and this issue has been fixed in the latest 2.0.18 beta.