Default SignOutUrl in functions.render.php method doesn't use Gdn::Authenticator
Hi,
while playing around with sso options for drupal and vanilla, I have found something when trying to single sign out :
the default method which generates the sign out link doesn't use the Gdn::Authenticator->SignOutUrl() method.
in functions.render.php :
if (!function_exists('SignOutUrl')) { function SignOutUrl($Target = '') { return '/entry/signout?TransientKey='.urlencode(Gdn::Session()->TransientKey()).($Target ? '&Target='.urlencode($Target) : ''); } }
So overriding $Configuration['Garden']['Authenticator']['SignOutUrl'] in config.php has no effect.
Shouldn't it be something like :
if (!function_exists('SignOutUrl')) { function SignOutUrl($Target = '') { return Gdn::Authenticator()->SignOutUrl($Target); } }
Thanks in advance for your help,
David
Best Answer
-
Todd Vanilla Staff
We are slowly moving away from the authenticator and setting the signout url in the config will no longer work. There are a couple of strategies you can use to change your signout url.
- Add a route that redirects to your preferred signout page.
- Add a
EntryController_BeforeSignOut_Handler()
orEntryController_SignOut_Handler()
function to a plugin and do what you want there.
0
Answers
this plugin is shipped with the core so you can report this here:
https://github.com/vanillaforums/Garden/issues
grep is your friend.
We are slowly moving away from the authenticator and setting the signout url in the config will no longer work. There are a couple of strategies you can use to change your signout url.
EntryController_BeforeSignOut_Handler()
orEntryController_SignOut_Handler()
function to a plugin and do what you want there.Thanks for these answers !
I will go for a Vanilla Plugin !