[GitHub Bug #1343] Event issue in class.activitymodel.php - BeforeSendNotification

JonnySchnittger

The event BeforeSendNotification is only raised when the user has enabled the email option in preferences.

function: SendNotification

if ($Force) $Preference = $Force; else { $Preferences = $User->Preferences; $Preference = ArrayValue('Email.'.$Activity->ActivityType, $Preferences, Gdn::Config('Preferences.Email.'.$Activity->ActivityType)); }

....

$this->FireEvent('BeforeSendNotification'); try { $Email->Send(); $Emailed = 2; // similar to http 200 OK }

function: SendNotificationQueue

if (is_object($Email)) { $this->EventArguments = $Notification; $this->FireEvent('BeforeSendNotification'); ....

This means any custom addons that rely on this event will not work.

A suggested fix would be to check all non-standard preferences for the $Activity->ActivityType and in the event of a custom activity being enabled call

$this->FireEvent('BeforeSendNotification');

x00

these issues should be reported to github

https://github.com/vanillaforums/Garden/issues

JonnySchnittger

Looks like this is the same issue as here: vanillaforums.org/discussion/15208/notifications-not-working-non-inbox-in-v2-0-17-8#Item_0

JonnySchnittger

and probably here too: vanillaforums.org/discussion/19249

x00

these issues should be reported to github

https://github.com/vanillaforums/Garden/issues

JonnySchnittger

Bug raised here: https://github.com/vanillaforums/Garden/issues/1343