"Add Comments 1": HTML tags show, rather than marking up text, if not logged in

ddavis

We are running this add-on at the WSO discussions. If you are not logged in, and you put a comment with some html tags, such as the blockquote tag, or a link to a URL, and then you press "add comment," forgetting to log in, the html tags show, instead of marking up the text.

For example, if one puts "This is a test quote." in blockquote tags, and "This is a test link" with a link going to wso.williams.edu in link tags, one hopes to get:

This is a test quote.

This is a test link.

However, if one clicks to post, forgetting to sign in, one understandably gets the error message:

Some problems were encountered
You did not supply a valid username.
You did not supply a valid password.

however, in the comment box, the previously-written comment text displayed is:

lt;blockquote gt;This is a test quote. lt;/blockquote gt;

lt;a href= quot;http://wso.williams.edu quot; gt;This is a test link. lt;/a gt;

(with ampersands in appropriate places)

This appears to be a bug that should be addressed on your end. If it is not, please tell us what we can do to fix it.

Thank you.

Mark

I've really got to get comments set up in the add-ons directory so extension related bugs are handled there... What version of PHP are you running?

NickE

I would think this has something to do with Vanilla in conjunction with the AddComments extension managing to call the Comment::FormatPropertiesForDisplay() function twice (or at least doing something along those lines).

Mark

I know, but I've seen things get formatted twice as a result of PHP 5's object references as well.

ddavis

We're running PHP 5.1.4.

Mark

Okay, I bet I know what it is then

Mark

Fixed and uploaded. Damn - these bugs are old. Sorry