HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

I thought I found a bug, but nevermind.

GaryFunkGaryFunk Senior Application Developer ✭✭
edited March 2013 in Feedback
$ComArray = Array(0, 1, 10, 100, 500, 1000, 2500, 5000, 10000);
for ($counter = 1; $counter <= $CountCB; $counter++) {
     echo Img($prelink . $counter . "comment.png", array('alt' => 'Comments', 'title' => sprintf(T('Comment %s'), $ComArray[$counter]), 'class' => "PeregrineBadgesSmall"));
}

You are not using ComArray to check the number of comments.

Comments

  • peregrineperegrine MVP
    edited March 2013

    @GaryFunk said:

    You are not using ComArray to check the number of comments.

    no I'm using for badge count as it should be.

    It doesn't show number of comments - it give the title the name of the badge e.g.

    comment 1 badge
    comment 1000 badge

    etc.

    no bug, intentional - same way the vanilla forum badge hover works.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • GaryFunkGaryFunk Senior Application Developer ✭✭
    edited March 2013

    Okay, I get part it, however, A person with only 2 comments is getting the 2nd badge.

  • peregrineperegrine MVP
    edited March 2013

    .

    Are you using the original version 1.4 or are you using something you modified that were untested:)

    I'll look at it later maybe tomorrow, if you are sure.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • GaryFunkGaryFunk Senior Application Developer ✭✭
    edited March 2013

    It's me. I can't help a 5th grader AND write code at the same time.

    I apologize.

  • peregrineperegrine MVP
    edited March 2013

    @GaryFunk said:
    It's me. I can't help a 5th grader AND write code at the same time.

    I apologize.

    no prob.

    Actually - you helped me find a small bug which I just fixed

    badges were awarded after +1 of each count of the number instead at the exact count.

    so in the old program you needed 2 comments to get the first badge
    or 101 likes to get the 100 like badge and so on.

    but ver 1.5 fixed that.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • Gary - I found a bug also in your title

    Senior Application Developoer

    perhaps it should be

    Senior Application Developer

    :)

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • GaryFunkGaryFunk Senior Application Developer ✭✭

    I'm a programmer that can't type and can't spell. Go figure.

  • peregrineperegrine MVP
    edited March 2013

    @GaryFunk

    did you get your single badge squared away.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • GaryFunkGaryFunk Senior Application Developer ✭✭

    I did, once I pulled my head out. It was really easy.

  • great, i was a bit tired myself yesterday.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

Sign In or Register to comment.