Missing Activity Log: "[user] changed his profile picture"

Aolee · January 2014

Hi people,

Just want to ask those who are using vanilla 2.1 , not sure if its only my forum. when i tried changing my profile pic. I don't see anymore in recent activity page the message saying "[user] changed his profile picture" . was it removed on 2.1? Thanks.

Aolee

peregrine · January 2014

problem is with the current code $OldPhoto will actually always be equal to $Photo because the check is made too late. Therefore an activity record will never be written.

Yes I believe you found a bug in

/applications/dashboard/models/usermodel.php

to make it add to activity and check photo correctly...
you could change the code form

                 $this->SQL->Put($this->Name, $Fields, array($this->PrimaryKey => $UserID));

                   // Record activity if the person changed his/her photo.
                   $Photo = ArrayValue('Photo', $FormPostValues);
                   if ($Photo !== FALSE) {
                      if (GetValue('CheckExisting', $Settings)) {
                         $User = $this->GetID($UserID);
                         $OldPhoto = GetValue('Photo', $User);
                      }



to


                  if (GetValue('CheckExisting', $Settings)) {
                         $OldPhoto = GetValue('Photo', $User);
                      }

                   $this->SQL->Put($this->Name, $Fields, array($this->PrimaryKey => $UserID));

                   // Record activity if the person changed his/her photo.
                   $Photo = ArrayValue('Photo', $FormPostValues);

                   if ($Photo !== FALSE) {
                      if (GetValue('CheckExisting', $Settings)) {
                      $User = $this->GetID($UserID);
                      //   $OldPhoto = GetValue('Photo', $User);
                  }

peregrine · January 2014

@Aolee said:
that's perfect! Thanks Peregrine!

no prob. glad it worked. nice find.

I put your "issue" on github with above solution.

https://github.com/vanillaforums/Garden/issues/1774

peregrine · January 2014