Howdy, Stranger!

It looks like you're new here. If you want to get involved, click one of these buttons!

Try Vanilla Forums Cloud product
Vanilla 2.6 is here! It includes security fixes and requires PHP 7.0. We have therefore ALSO released Vanilla 2.5.2 with security patches if you are still on PHP 5.6 to give you additional time to upgrade.

Plugin uses deprecated "CommentData" instead of "Data('Comments')"

This discussion is related to the Thankful People 2 addon.
AccentAccent
edited August 2014 in Feedback

Hi,

When turning on debug view with the plugin enabled, discussions break completely. The reason is that the plugin uses the now deprecated DiscussionController->CommentData on line 90 of class.thankfulpeople.plugin.php.

Changing it to Data('Comments') seems to solve the issue – the whole line would be:

$CommentIDs = ConsolidateArrayValuesByKey($Sender->Data('Comments')->Result(), 'CommentID');

After the fix the discussions display two bits of debug info though:

CommentModel->PageWhere()

Comment.Page.30.33.1: false

CommentModel->CachePageWhere()
Comment.Page.30.33.1: array ( 0 => '2014-08-05 09:05:41', )

Not sure if that's important.

Cheers.

R_JhgtonightUnderDogShadowdare
Sign In or Register to comment.