Blog Documentation Book a Demo
Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

Little problem with popups

2

Comments

  • vrijvlindervrijvlinder MVP

    I recall this happening to other people using bootstrap , it turned out to be a Js problem but will need to search for the discussion

    ❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌

  • peregrineperegrine MVP
    edited September 2014

    I installed you theme zip file.

    and the user box pops up without a white space or line in popup in firefox and google and appears normally.

    you might turn off all caching and minimizers and delete the .ini files in your cache folder.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • peregrineperegrine MVP
    edited September 2014

    Did you follow the upgrade instructions EVERY step here.

    including
    http://vanillaforums.org/discussion/26685/vanilla-2-1-stable-released/p1

    Delete the files

    /themes/mobile/views/discussions/helper_functions.php AND
    /applications/dashboard/views/default.master.php

    do you have the same issue with the bittersweet theme?

    I just move from an old version to 2.1

    you also say you are using vanilla 2.1, I would upgrade to vanilla 2.1.1

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • vrijvlindervrijvlinder MVP
    edited September 2014

    This may be another unicode problem ?

    http://vanillaforums.org/discussion/comment/212275/#Comment_212275

    What editor do you use for the tpl ?

    ❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌

  • DarkSharedDarkShared New

    I am using notepad++ and yes, I followed the instruccions and deleted the files.

    With the bitterseet theme there's no problem.

    With the grayscale blue there's no problem in IE10, but the problem persist in Chrome, Firefox and earlier versions of IE.

    In Firefox and IE all the things should go in the head (css, js...) are rendered inside the head, in Chrome they are rendered in the body.

    @Peregrine, which browser did you use?

    I will update to 2.1.1 tomorrow and see whats happens.

    Thanks a lot guys.

  • peregrineperegrine MVP

    firefox v31

    chromium version 36

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • vrijvlindervrijvlinder MVP
    edited September 2014

    I would rewrite the default.master.php, try this

    <?php echo '<?xml version="1.0" encoding="utf-8"?>'; ?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-ca">
<head> <?php $this->RenderAsset('Head');?>

<script type="text/javascript">
 var RecaptchaOptions = {
    theme : 'blackglass'
 };
 </script>

</head>
<body id="<?php echo $BodyIdentifier; ?>" class="<?php echo $this->CssClass; ?>">
   <div id="Frame"><div class="Row">
      <div id="Head">
<h1><a><span><?php echo Gdn_Theme::Logo(); ?></span></a></h1>       
 <div class="Menu">

            <?php
                  $Session = Gdn::Session();
                    if ($this->Menu) {

                                             $this->Menu->AddLink('Dashboard', T('Dashboard'), '/dashboard/settings', array('Garden.Settings.Manage'));
                         $this->Menu->AddLink('Edit Profile', T('Edit Profile'),'/profile/edit',array('Garden.SignIn.Allow'),array('title'=>'Edit Your profile'));
                         $this->Menu->AddLink('Home', T('Home'),'/');
                         $this->Menu->AddLink('Activity', T('Activity'), '/activity',array('Garden.SignIn.Allow'));
                         $this->Menu->AddLink('New Discussion',T('New Discussion'), 'post/discussion',array('Garden.SignIn.Allow'));
                         $this->Menu->AddLink('New Message', T('New Message'), '/messages/add/{Username}',array('Garden.SignIn.Allow'), array('class' => 'Messagelink'));
                          $this->Menu->AddLink('Mobile View', T('Mobile View'), 'profile/mobile');

                      // $this->Menu->AddLink('Dashboard', T('Users'), '/user/browse', array('Garden.Users.Add', 'Garden.Users.Edit', 'Garden.Users.Delete'));                     



$Authenticator = Gdn::Authenticator();
                        if ($Session->IsValid()) {
                            $Name = $Session->User->Name;
                            $CountNotifications = $Session->User->CountNotifications;
                            if (is_numeric($CountNotifications) && $CountNotifications > 0)
                                $Name .= ' <span>'.$CountNotifications.'</span>';

                            $this->Menu->AddLink('User', $Name, '/profile/{UserID}/{Username}', array('Garden.SignIn.Allow'), array('class' => 'UserNotifications'));

                            $this->Menu->AddLink('SignOut', T('Sign Out'), $Authenticator->SignOutUrl(), FALSE, array('class' => 'NonTab SignOut'));
                        } else {
                            $Attribs = array();
                            if (C('Garden.SignIn.Popup') && strpos(Gdn::Request()->Url(), 'entry') === FALSE)
                                $Attribs['class'] = 'SignInPopup';

                            $this->Menu->AddLink('Entry', T('Sign In'), $Authenticator->SignInUrl($this->SelfUrl), FALSE, array('class' => 'NonTab'), $Attribs);
                        }
                        echo $this->Menu->ToString();}?>

         </div>
      </div></div>
      <div id="Body"><div id="Panel"><?php $this->AddModule('MeModule');?>

<div class="Search">

    <?php           $Form = Gdn::Factory('Form');
                    $Form->InputPrefix = '';
                    echo 
                        $Form->Open(array('action' => Url('/search'), 'method' => 'get')),
                        $Form->TextBox('Search'),
                        $Form->Button('Go', array('Name' => '')),
                        $Form->Close(); ?>
                    </div>



<?php $this->RenderAsset('Panel');?></div>         
          <div id="Content"><?php $this->RenderAsset('Content');?></div>


         </div>

      </div>

<?php $this->FireEvent('AfterBody'); ?>
<div class="Foot"><?php $this->RenderAsset('Foot'); echo Wrap(Anchor(T('Vanilla'), C('Garden.VanillaUrl'),array('target' => '_blank')), 'div');?>
</body>
</html>

    ❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌

  • peregrineperegrine MVP
    edited September 2014

    In HTML5 there is only one DOCTYPE declaration, and it is very simple:

    <!DOCTYPE html>

    http://www.w3schools.com/html/html5_intro.asp

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • vrijvlindervrijvlinder MVP

    yes but his master is a php according to that theme ... so it strict/transitional

    ❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌

  • vrijvlindervrijvlinder MVP

    Here is all the types and what they do

    http://www.w3schools.com/tags/tag_doctype.asp

    Common DOCTYPE Declarations
HTML 5

<!DOCTYPE html>
HTML 4.01 Strict

This DTD contains all HTML elements and attributes, but does NOT INCLUDE presentational or deprecated elements (like font). Framesets are not allowed.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
HTML 4.01 Transitional

This DTD contains all HTML elements and attributes, INCLUDING presentational and deprecated elements (like font). Framesets are not allowed.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
HTML 4.01 Frameset

This DTD is equal to HTML 4.01 Transitional, but allows the use of frameset content.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Frameset//EN" "http://www.w3.org/TR/html4/frameset.dtd">
XHTML 1.0 Strict

This DTD contains all HTML elements and attributes, but does NOT INCLUDE presentational or deprecated elements (like font). Framesets are not allowed. The markup must also be written as well-formed XML.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
XHTML 1.0 Transitional

This DTD contains all HTML elements and attributes, INCLUDING presentational and deprecated elements (like font). Framesets are not allowed. The markup must also be written as well-formed XML.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
XHTML 1.0 Frameset

This DTD is equal to XHTML 1.0 Transitional, but allows the use of frameset content.

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">
XHTML 1.1

This DTD is equal to XHTML 1.0 Strict, but allows you to add modules (for example to provide ruby support for East-Asian languages).

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">

    ❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌

  • peregrineperegrine MVP
    edited September 2014

    I guess i assume all borwsers these days are using html5

    so for me html5 is good enough

    therefore <!DOCTYPE html> In HTML5 there is only one DOCTYPE declaration

    you are talking about html 4, I'm not.

    also

    <script> in html5 without type is sufficient


you don't need 
`<script type="text/javascript">`

    The type attribute gives the language of the script or format of the data. If the attribute is present, its value must be a valid MIME type. The charset parameter must not be specified. The default, which is used if the attribute is absent, is "text/javascript".

    http://www.w3.org/TR/html5-diff/

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • vrijvlindervrijvlinder MVP

    Yes it does simplify things and the Vanilla default master is an html5 doc.

    ❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌

  • peregrineperegrine MVP
    edited September 2014

    @vrijvlinder said:
    Yes it does simplify things and the Vanilla default master is an html5 doc.

    a bit of a mish-mash different Doctypes through out the vanilla source some html5 some html 4.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • x00x00 MVP

    I think this a bit of red hearing guys. The problem is malformed mark-up not doctypes.

    Back on topic @DarkShared does the theme have a themehook file? Can you post that, and the default master.

    grep is your friend.

  • peregrineperegrine MVP
    edited September 2014

    just commenting on improvements along the way.

    x00 here's the zip

    http://vanillaforums.org/discussion/comment/214449/#Comment_214449

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • x00x00 MVP

    @peregrine said:
    just commenting on improvements along the way.

    I make the discussion difficult to follow, and can be confusing as are shotgun debugging suggestions.

    @DarkShared is there are reason why you need all those view overrides?

    grep is your friend.

  • peregrineperegrine MVP
    edited September 2014

    x00 I agree with you, we went off-topic.

    99.99% of the time, i agree with you. This is the other .01% :) As far as the shotgunning, I commented on vri's proposed code.

    here was his response, when I asked him essentially the same questions.

    http://vanillaforums.org/discussion/comment/214454/#Comment_214454

    http://vanillaforums.org/discussion/comment/214457/#Comment_214457

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • x00x00 MVP

    Sorry that wasn’t meant to be accusatory.

    grep is your friend.

  • x00x00 MVP

    If you are updating from non 2.1 theme with lot of view overrides, you really need to recreate these views in 2.1. You could cause all sort of issues otherwise. Just a cursory look there is already mark-up issues, it is worth validating, to catch thing like unclosed tags.

    grep is your friend.

  • x00x00 MVP

    Also the edit user popup you would expect to be in the standard dashboard theme, the style you have shown in he pic doesn't match that.

    grep is your friend.

Sign In or Register to comment.