Flyout close and unneeded ULs

thermite

It seems for Flyouts (e.g. cog menu) to close by clicking elsewhere on the page, the content of the page must be wrapped in something with id 'Body' - The 'Flyout' is controlled in /js/global.js which contains the following line around line 809:
$(document).delegate('#Body', 'click', function() {
This theme doesn't have that. It's weird to require a #Body tag I think, but there you go...

Also it seems in the nav, the MeModule is wrapped in a UL, and I don't understand why, there is no list there. Possibly the sign in link too.

Bleistivt

I explained why the event need to be delegated in the other thread.

As for issues you have with Bootstrap, report them on github, Kasper will not respond here.

thermite

The issue is that the #Body tag is missing from this theme. It is a shame the developer will not see this I'm sure someone else will encounter this and perhaps this will help them anyway.

Bleistivt

He will see it if you file an issue on github
From the plugin description:

Issue tracking

If you come across any bugs or if you have a feature request, please file an issue using the GitHub Issue tracker. Bootstrap for Vanilla won't be supported through http://vanillaforums.org so please stick to using GitHub for inquiries about bugs and feature requests. Thanks!

thermite

I know, I tried, but you have to login, and to login you have to register.... it's all just too much.

whu606

Sorry, @thermite, but Kasper has probably spent hundreds and hundreds of hours producing Bootstrap, so you and others can have it for free, but it is too much for you to register on GitHub?

Really?

And you think that is reasonable?

peregrine

@thermite said:
I know, I tried, but you have to login, and to login you have to register.... it's all just too much.

It's a tough life

Kasper

This issue was fixed by the undersigned last year in master: https://github.com/vanilla/vanilla/commit/184d41789698ef63a070df421e1e81a7a75c5a32