Activationlink strange bug

Schryvers

vanilla 2.1.3
hello this is my activation email in dutch:

Beste test,

Je hebt je succesvol geregistreerd als lid bij website.nl! Hier zijn je gegevens:

Gebruikersnaam: test
E-mail: test@gmail.com

Klik op de volgende link: http://www.website.nl/entry/emailconfirm/34/0Y1O7W3A om je account te bevestigen.

Je kunt de website bezoeken op http://www.website.nl
Een hele fijne dag verder!

---

So i get some PM's from users that they cannot activate there account via the email.

they get this link:

http://www=.website.nl/entry/emailconfirm/34/0Y1O7W3A
(As you can see after the www there is a = )

What causes this? 3 users had it, i register 2 accounts by myself today but theres no = in the link, so thats good.

But the 3 other people defenitly have the = in their emailmap so they cant activate (they can, after deleting the = )

Very strange

Bleistivt

Content-Transfer-Encoding: quoted-printable

There are various reports about that happening with the quoted-printable encoding on hotmail/live/outlook.

@Schryvers, could you try changing this line:
https://github.com/vanilla/vanilla/blob/181194/library/core/class.email.php#L45

to

$this->PhpMailer->Encoding = '8bit';

If it fixes your issue, I will submit a pull request.

Schryvers

This is the email some hotmail users get:

---

Beste user,

Je hebt je succesvol geregistreerd als lid bij Tat=
tooTalk.nl! Hier zijn je gegevens:

Gebruikersnaam: user

E-mail: user@hotmail.com

Klik op de volgende link: http://www=
.website.nl/entry/emailconfirm/33/L8SLH1M3 om je account te bevestigen.=

Je kunt de website bezoeken op http://www.website.nl

Een h=
ele fijne dag verder!

• website.nl

---

Very strange and more users have this on my forum but it seems only by hotmail users.

vrijvlinder

What do you have in your config.php for see if that affects anything change to html if it says plain

$Configuration['Garden']['Email']['MimeType']= 'text/html';

Schryvers

@vrijvlinder,

That line i dont have in my config, dont have any lines that says plain or text/html or even garden/email/mimetype

A other user send me their screenshot from the activation link,

seems that the = character displays on other places in each email.

If i place the code
$Configuration['Garden']['Email']['MimeType']= 'text/html';

in config, the email still has the = in the email, and the email gets fucked up... see:

Am i the only one with this problem? Or maybe it is an problem in vanilla? Seems to be by hotmail users only....

vrijvlinder

If it is only hotmail users go to the hotmail forum and see if anyone else has this issue or look in google " hotmail messes up my links"

Schryvers

cant find anything. How strange is this wow.

Messes up my mind

Schryvers

When im looking at a good activation email in my gmail, and i select the option of gmail: Original,

then i see this:

From: TattooTalk noreply@www.tattootalk.nl
Message-ID: 56d155c90dcb2002b070c8b314f38be3@www.tattootalk.nl
X-Priority: 3
X-Mailer: PHPMailer 5.1 (phpmailer.sourceforge.net)
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Beste test,=0A=0AJe hebt je succesvol geregistreerd als lid bij TattooTalk.=
nl! Hier zijn je gegevens:=0A=0A Gebruikersnaam: test=0A E-mail: emailadres=
@gmail.com=0A=0AKlik op de volgende link: http://www.tattootalk.nl/entry/em=
ailconfirm/34/0Y1O7W3A om je account te bevestigen.=0A =0AJe kunt de webs=
ite bezoeken op http://www.TattooTalk.nl=0A=0AEen hele fijne dag verder!=0A=
=0A- TattooTalk.nl

Schryvers

Another one... ALL VANILLA FORUMS HAVE IT!
@vrijvlinder @piotrnl

Bleistivt

Content-Transfer-Encoding: quoted-printable

There are various reports about that happening with the quoted-printable encoding on hotmail/live/outlook.

@Schryvers, could you try changing this line:
https://github.com/vanilla/vanilla/blob/181194/library/core/class.email.php#L45

to

$this->PhpMailer->Encoding = '8bit';

If it fixes your issue, I will submit a pull request.

Schryvers

@bleistivt
That solved the problem!

Now when i select "Show original source" its coming up right, even as the normal display of emails:

From: TattooTalk noreply@www.tattootalk.nl
Message-ID: 3b49ffa4aaa9769e4a4d89a8bd1ed4d9@www.tattootalk.nl
X-Priority: 3
X-Mailer: PHPMailer 5.1 (phpmailer.sourceforge.net)
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
Return-Path: noreply@www.tattootalk.nl
X-OriginalArrivalTime: 30 Oct 2014 01:48:01.0113 (UTC) FILETIME=[89BE9C90:01CFF3E3]

Beste user,

Je hebt je succesvol geregistreerd als lid bij TattooTalk.nl! Hier zijn je gegevens:

Gebruikersnaam: user
E-mail: user@hotmail.com

Klik op de volgende link: http://www.tattootalk.nl/entry/emailconfirm/40/SQ2274ZC om je account te bevestigen.

Je kunt de website bezoeken op http://www.TattooTalk.nl

Een hele fijne dag verder!

• TattooTalk.nl

---

Tested 3 times with different hotmail accounts (works!)

Tested 2 times with different gmail account (still works!)

Schryvers

@bleistivt so this is an real "missing" thing in original vanilla? This solves the problem 100% i tested it for about 30 minutes now and it seems on 20 emails, 20 times good. So seems to be right that that line need to be changed on the original vanilla right?

Good work!!! Thanks!

@piotrnl

Bleistivt

8bit is the phpMailer default, but they changed it to circumvent a different bug:

https://github.com/vanilla/vanilla/commit/0fae36

Schryvers

So what now?

Bleistivt

As you are probably not using SendGrid, you can safely change it to 8bit.

Just found out it's actually a bug with the mail library included in vanilla. Updating that library should fix it.

lfolco

Does anyone know if it's still a bug in SendGrid? I hate to make changes to source files but I'm running into this issue as well.

JoosBuijs

I'm also having this issue on Vanilla 2.2b1. Applying the change suggested by Belistivt works, but a less-intrusive (and update-proof) solution would be welcome.