JPEG Only Supported

agcyphers

Uploading PNG or GIF files appears to strip the transparency (the image is saved as JPG). Could we get transparency supported added?

agcyphers

Fixed it myself. Changed "jpg" in GenerateTargetName call and SaveImageAs call to "png".

agcyphers

Here's a more in-depth fix (detect image type). Beginning at line 446, through 476.

        $imageType = end(explode('.', $_FILES[$UploadFieldName]['name']));
        $suppTypes = array('jpg', 'png', 'gif', 'ico', 'jpeg');
        if( in_array($imageType, $suppTypes) === false ) {
            $imageType = 'jpg';
        }

        // Generate the target image name.
        $CurrentYear = date('Y');
        $CurrentMonth = date('m');
        $UploadPath = PATH_UPLOADS . '/articles/' . $CurrentYear . '/' . $CurrentMonth;
        $TargetImage = $UploadImage->GenerateTargetName($UploadPath, $imageType, false);
        $Basename = pathinfo($TargetImage, PATHINFO_BASENAME);
        $UploadsSubdir = '/articles/' . $CurrentYear . '/' . $CurrentMonth;

        if($isThumbnail) {
            $SaveWidth = C('Articles.Articles.ThumbnailWidth', 260);
            $SaveHeight = C('Articles.Articles.ThumbnailHeight', 146);
        } else {
            $SaveWidth = null;
            $SaveHeight = null;
        }

        // Save the uploaded image.
        $Props = $UploadImage->SaveImageAs(
            $TmpFileName,
            $UploadsSubdir . '/' . $Basename,
            $SaveHeight,
            $SaveWidth, // change these configs and add quality etc.
            array('OutputType' => $imageType, 'ImageQuality' => C('Garden.UploadImage.Quality', 75))
        );

Shadowdare

Will consider adding transparency support for image uploads in a future release. Thanks, @agcyphers!

Bleistivt

If you set the second parameter of GenerateTargetName to FALSE, it will figure out the extension by itself.

Shadowdare

@Bleistivt, thanks for the tip! I'll probably set the second argument to false for the $UploadImage->GenerateTargetName() call. Also, it looks like validating the extension against an array of allowed extensions isn't necessary as $UploadImage->ValidateUpload() throws an exception for uploads that aren't images.

agcyphers

The purpose of that validation was to have a default extension of jpg if no others were found. Probably not the best way to do it.