User Filters add-on produces error

Mav

On the account page, I get this error on top: Notice: Undefined variable: AccountUserID in /var/www/html/vanilla/extensions/userfilters/default.php on line 24 Also, it does create the links, but it's labeled "'s Activity" instead of "Username's Activity". I don't think the links are good either, it's searching with: "vanilla/search/?PostBackAction=Search&Type=Discussions&Advanced=1&Keywords=&Categories=&AuthUsername=&btnSubmit=Search" for discussions, and: "vanilla/search/?PostBackAction=Search&Keywords=:&Type=Comments&btnSubmit=Search" for comments. Anyone else had this problem or knows how to fix this?

Dinoboff

you can try adding before line 23$AccountUserID = ForceIncomingString('u', '');or
$AccountUserID = ForceIncomingString('u', $Context->Session->UserID);

Mav

That didn't quite work but it pointed me to the right direction. I found something similar in another add-on, IpHistory:

// Don't reload objects if you don't need to (ie. If another extension has already loaded it) if (!@$UserManager) $UserManager = $Context->ObjectFactory->NewContextObject($Context, "UserManager"); $AccountUserID = ForceIncomingInt("u", $Context->Session->UserID);

I just put that in there instead, and it worked. Thanks.

houseinprogress

So given I'm not getting this error please confirm before I make this edit to 1.0.1. You added the string above before line 23 (below). It doesn't replace it, right?

//Define the account that is being viewed $UserManager = $Context->ObjectFactory->NewContextObject($Context, 'UserManager'); $AccountUser = $UserManager->GetUserById($AccountUserID);

Dinoboff

I think you have to replace //Define the account that is being viewed $UserManager = $Context->ObjectFactory->NewContextObject($Context, 'UserManager'); $AccountUser = $UserManager->GetUserById($AccountUserID);
by//Define the account that is being viewed // Don't reload objects if you don't need to (ie. If another extension has already loaded it) if (!@$UserManager) $UserManager = $Context->ObjectFactory->NewContextObject($Context, "UserManager"); $AccountUserID = ForceIncomingInt("u", $Context->Session->UserID); $AccountUser = $UserManager->GetUserById($AccountUserID);

jimw

I just added the lines of code suggested by Mav before your //Define the account code and it worked (for me). I didn't replace anything.

houseinprogress

Dinoboff - makes sense, I've uploaded 1.0.2 with your suggestion.

Mav

I only added it above line 23, I didn't replace anything. But what Dinoboff said is correct. I just forgot to remove the original "$UserManager =..." line.