Email Confirmation link throws a fatal error

The_Tim

I'm running a new Vanilla 2.2 setup. I installed fresh and imported data from my old phpBB forum.

In the registration settings I've set the method to "Basic" and checked the box for "Require users to confirm their email addresses (recommended)"

However, when a new user tries to click on the confirmation link that is emailed to them, they get sent to the "Something has gone wrong." page.

I turned on debug, and got the error "Fatal Error in PHP.trigger_error();"

I can't figure out what's going on. Can anyone help me out?

x00

There is no error message so that is a bug in itself. it is assuming it is a PDO error it mightn't be

I've added a bug report.

The_Tim

Thanks... Any idea for a workaround other than disabling email verification (which I would prefer not to do of course)?

x00

The issue is not your error by errors in general in that context not showing up.

You could

https://github.com/vanilla/vanilla/blob/master/library/database/class.database.php#L413-L423

add

If (!$message) {
    trigger_error($ex->getMessage(), E_USER_ERROR);
}

after

list($state, $code, $message) = $PDO->errorInfo();

around line 414 in library/database/class.database.php

That will give you the actual error.

The_Tim

That is definitely helpful. After adding that I get a real error:

Fatal Error in Gdn_Database.Query();

Duplicate entry '1839-8' for key 'PRIMARY'
insert GDN_UserRole
(UserID, RoleID)
values (:UserID, :RoleID)

x00

I suspect you have duplicate rows in GDN_UserRole

delete duplicates where the UserID and RoleID are the same, leaving just one of each.

The_Tim

I just checked and I don't have any duplicates in the GDN_UserRole table. There is definitely something odd going on though, because the GDN_Role table does not even have a Role with RoleID 8, but for some reason a new row in GDN_UserRole with RoleID 8 is being created for new users.

Here are all my roles:

Here's what the GDN_Role table looks like:

I open an incognito window and register a new test account called TestAccount12, then I run this query:

SELECT
  UR.UserID,
  U.Name AS User_Name,
  UR.RoleID,
  R.Name AS Role_Name
FROM GDN_UserRole UR
  LEFT JOIN GDN_Role R ON R.RoleID = UR.RoleID
  LEFT JOIN GDN_User U ON U.UserID = UR.UserID
ORDER BY UserID DESC;

This is what I see:

As you can see above, there is no role with RoleID 8. So why was that inserted into the table? And why is it apparently attempting to insert it again when the user confirms their email?

Also, why are brand new users who haven't confirmed their email yet being given the role "Members" and not "Unverified Members" or "Applicants"?

peregrine

Also, why are brand new users who haven't confirmed their email yet being given the role "Members" and not "Unverified Members" or "Applicants"?

in 2.1 if you have the config settings correct they should be given the unconfirmed role. Upon confirmation they should be given member role.

Applicants is only for applicant approval.

Member Role is standard 8.

people who have ported from other databases have had roles and permissions munged up and have different numbers.

this may help.
you can set the default roles here...

http://vanillaforums.org/discussion/comment/219688/#Comment_219688

if it were me and I had the time I would migrate all members to role id 8

change the member role to role id 8 in the role table and

set all roles with roleid 11 to 8 in user role table.

all done carefully of course.

Personally I would use applicant approval and forget about email confirmation totally.
thats just my opinion

The_Tim

Okay, per your suggestion I manually edited the RoleID for each of the standard roles to match the defaults (as found in the definition of $RoleModel in /applications/dashboard/settings/structure.php then I manually reset all the permissions per Q19 in the FAQ link you provided.

After doing all that, things seem to be working as expected. So it definitely looks like there are some bugs that pop up if you modify the default roles in 2.2. Anyway, things seem to be working as desired now.

Thanks!