Comment Protection bug?

bjrn · August 2006

Here on this forum, blocking a user doesn't seem to stick for me. I can block someone, but eventually they become unblocked. Is blocking just for a session, or a short period, or is it supposed to be permanent?

mary · August 2006

I think it's just for session.

Mark · August 2006

It should be permanent, actually. I haven't tested it in a long time, I'll have to check it out. It could have something to do with that account form bug which resets all preferences, though.

a_magical_me · August 2006

Did we ever fix that?

Mark · August 2006

Yes, I've fixed it now in svn.

a_magical_me · August 2006

I've solved the mystery of the disappearing user blocks: The RemoveUserBlock function in the UserManager is using $s->AddFieldNameValue() rather than $s->AddWhere(), which is meaningless when deleting rows. So whenever anyone unblocks a user, the entire contents of the LUM_UserBlock table is deleted.

a_magical_me · September 2006

*bump* Mark, it would be awesome if you would fix this.

bjrn · April 2007

Looks like this is still happening. I just tried blocking a_magical_me, Mark and mary. Then I unblocked mary, and suddenly Mark and a_magical_me were unblocked as well.

WallPhone · April 2007

Sure enough:

	function RemoveUserBlock($UserID) {
		$s = $this->Context->ObjectFactory->NewContextObject($this->Context, 'SqlBuilder');
		$s->SetMainTable('UserBlock', 'b');
		$s->AddFieldNameValue('BlockingUserID', $this->Context->Session->UserID);
		$s->AddFieldNameValue('BlockedUserID', $UserID);
		// Don't stress over errors (ie. duplicate entries) since this is indexed and duplicates cannot be inserted
      $this->Context->Database->Delete($s, $this->Name, 'RemoveUserBlock', 'An error occurred while removing the user block.', 0);
	}

should probably (untested) be

	function RemoveUserBlock($UserID) {
		$s = $this->Context->ObjectFactory->NewContextObject($this->Context, 'SqlBuilder');
		$s->SetMainTable('UserBlock', 'b');
		$s->AddWhere('b', 'BlockingUserID', '', $this->Context->Session->UserID, '=');
		$s->AddWhere('b', 'BlockedUserID', '', $UserID, '=');
      $this->Context->Database->Delete($s, $this->Name, 'RemoveUserBlock', 'An error occurred while removing the user block.', 0);
	}

Comment Protection bug?

Comments