Users running a non-download version of Vanilla (pulled from github), on branch release/2019.016 or master from the last 2 weeks should upgrade to release/2019.017 or latest master for security reasons. Downloaded official open sources releases are not affected.

plugin->isEnabled() has changed

This discussion is related to the Karma Bank addon.
R_JR_J Cheerleader & TroubleshooterMunich Moderator

I tried to add custom rules to your plugin but found that there is a problem with GDN_plugins isEnabled() method

I do not know how you would like to handle it: write a custom function in your plugin that handles both config formats or drop that call throughout that code. To be honest: I even got so confused that I'm not able to judge if there really is any problem at all...


Comments

  • R_JR_J Cheerleader & Troubleshooter Munich Moderator

    OMG! There is a function isEnabled so that you can implement a "second level" enable mechanism in plugins, correct?

    O.o


  • R_JR_J Cheerleader & Troubleshooter Munich Moderator

    Forget about that. Already the methods documentation shows how it should be used...


  • I always use c('EnabledPlugins.NAME') directly :D

    vrijvlinderRiver
  • R_JR_J Cheerleader & Troubleshooter Munich Moderator

    Recently I've seen plugins use a self made "IsConfigured" which makes sense to me: some plugins need to be configured before their output should be viewable by the users.

    But having a GDN_plugin->isEnabled() method that does not check if the plugin is enabled has confused me.


    River
  • Even more confusing anything within an individual plugin folder is mapped and registered to cache even if the plugin is disabled.

    Pragmatism is all I have to offer. Avoiding the sidelines and providing centerline pro-tips.

Sign In or Register to comment.