HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

Non-unique IDs in rich editor (vanilla 3.3)

Hi All,

default clean install of Vanilla 3.3 , the rich text editor uses non-unique IDs in the output html

console.log:

general:1 [DOM] Found 3 elements with non-unique id #paragraphMenu1-formattingMenusparagraphMenu1-formattingMenus-dropDown-button: (More info: https://goo.gl/9p2vKq) <button type=​"button" role=​"menuitem" id=​"paragraphMenu1-formattingMenusparagraphMenu1-formattingMenus-dropDown-button" aria-label=​"Toggle Heading Menu" title=​"Toggle Heading Menu" aria-controls=​"paragraphMenu1-formattingMenusparagraphMenu1-formattingMenus-dropDown-menu" aria-expanded=​"true" aria-haspopup=​"menu" class=​"richEditor-button_fb25bfp" tabindex=​"0">​<span class=​"richEditor-iconWrap_fxvwaji">​</span>​<svg class=​"richEditorButton-icon richEditor-icon_fhbc7gl" viewBox=​"0 0 24 24">​…​</svg>​<div class=​"sr-only">​Toggle Heading Menu​</div>​</button>​ <button type=​"button" role=​"menuitem" id=​"paragraphMenu1-formattingMenusparagraphMenu1-formattingMenus-dropDown-button" aria-label=​"Toggle Heading Menu" title=​"Toggle Heading Menu" aria-controls=​"paragraphMenu1-formattingMenusparagraphMenu1-formattingMenus-dropDown-menu" aria-expanded=​"false" aria-haspopup=​"menu" class=​"richEditor-button_fb25bfp" tabindex=​"-1">​…​</button>​ <button type=​"button" role=​"menuitem" id=​"paragraphMenu1-formattingMenusparagraphMenu1-formattingMenus-dropDown-button" aria-label=​"Toggle Heading Menu" title=​"Toggle Heading Menu" aria-controls=​"paragraphMenu1-formattingMenusparagraphMenu1-formattingMenus-dropDown-menu" aria-expanded=​"false" aria-haspopup=​"menu" class=​"richEditor-button_fb25bfp" tabindex=​"-1">​…​</button>​

Comments

  • in plugins/rich-editor/src/scripts/menuBar/paragraph/ParagraphMenusBarToggle.tsx

    line 78

    this.ID = uniqueId("paragraphMenu") + "-formattingMenus";
    

    Line 33

    import uniqueId from "lodash/uniqueId";
    

    That's about where knowledge ends :D

Sign In or Register to comment.