New "approver" role doesn't work. Help?

CLRAdmin

Hi everyone,

I created a new "Approver" role with the following roles checked off:

* Can sign-in
* Add comments
* Start discussions
* HTML & images allowed
* Sink discussions

* Approve applicants
* Notify by email of new applicants

My idea was to have a member user with special approval status that can do the approvals for me. While they can view new applicants and see the "Approve for Membership" link, all they get is a blank content area after clicking the link. As a result, the new applicant still isn't turned into a full time member.

Any ideas? Am I going about this in the wrong way? Should I be checking off additional roles?

I'd rather not give this "Approver" role too much power as they aren't very proficient with computers and I don't want them to mess anything up.

Thanks for any help you can offer! It's really appreciated.

- Matt.

Mark

Hmmm. It could be a bug. I've got a similar role here on this forum that I call "User Administrator". It has the following permissions: Can sign-in Add comments Start discussions HTML & images allowed Approve applicants Notify by email of new applicants Change user roles Edit any user IP addresses visible Registration configuration It works fine for me. Regardless, I'll try to duplicate your problem and see if it's a core issue.

Mark

Okay, so I looked and it was a bug. I've fixed it in subversion.

The following fix applies to Vanilla 1.0.1 ONLY:

Open library/People/People.Class.UserManager.php and change line 72 from this:

if (!$this->Context->Session->User->Permission('PERMISSION_CHANGE_USER_ROLE') && !$NewUser) {

to this:

if (!$this->Context->Session->User->Permission('PERMISSION_CHANGE_USER_ROLE') && $this->Context->Session->User->Permission('PERMISSION_APPROVE_APPLICANTS') && !$NewUser) {

CLRAdmin

Thanks for the quick reply! I tried the change in 1.0.0, but it didn't make a difference and I still show a blank content page. Does this change really require version 1.0.1 over 1.0.0? My main concern is that I've already had to modify some base code for read only categories, etc. and wouldn't want to have to do it all over again. I did do a search and see other references to PERMISSION_CHANGE_USER_ROLE, so I'm not sure why your code wouldn't work on 1.0.0. :-(

Mark

Well, I'm working with 1.0.1, so it should only apply to that version. I don't remember exactly what code changed between the two versions, so it could be that.

CLRAdmin

Oh well. I'll just give the user administrator rights if that allows her to approve new applicants.