How do I add a script in the header?

Ben

I want to add the following line into the header on all pages, unfortunately I can't seem to find where I would put this... <script type="text/javascript"> <!-- if( top != self ){ top.location=self.document.location; } //--> </script> It's to break the page out of frames as otherwise the login doesn't work on my server.

jonezy

you could write an extension i imagine...

if (@$Head) { $Head->AddScript($Context->StyleUrl."framebreaker.js"); }

and then have your js in an external file.

i looked at the PanelHider extension and just quickly edited it down.

jonezy

again, the documentation for extensions isn't available just yet.

Mark

If I were you, I'd put my javascript into a .js file. Then create a new extension following the same comment methods adopted by existing extensions (ie. name it, version number, your name, etc) and then the only real php you'll need to add is this:

$Head->AddScript("/path/to/your/js/file.js");

jonezy

wow did we just say the same thing but different?

Mark

There ya go. *wipes brow*

Ben

ok... I've created the following.

My Extension
<?php /* Extension Name: Break Frames Extension Url: http://soul-scape.com/ Description: Should add a script on every page to allow the site to break free from the constricting frames. Version: 1.0 Author: Ben Author Url: http://www.soul-scape.com/ */ $Head->Addscript("./js/BreakFrames.js"); ?>

My Javascript
if( top != self ){ top.location=self.document.location; }

Now this still doesn't seem to be working, I'm not familiar with the intricacies of JavaScript so any help would be appreciated...

jonezy

did you enable it in the admin? can we see a page where it would be ?

jonezy

just looking at your login page, it says that the file doesn't exist on the server? are you sure you uploaded it?

brady

while you're at it, give me a discussion list auto-refresher!

omfg

omg use the feed :X

jonezy

/* Extension Name: Break Frames Extension Url: http://soul-scape.com/ Description: Should add a script on every page to allow the site to break free from the constricting frames. Version: 1.0 Author: Ben Author Url: http://www.soul-scape.com/ */ if (in_array($Context->SelfUrl, array("index.php")) && $Context->Session->UserID > 0) { $Head->Addstring("META TAG TO REFRESH THE PAGE"); } ?>

thhat would probably work

Ben

Hmm, during uploading, it seems to have renamed the file to lowercase. Just adjusting the reference in the extension to lowercase has fixed it. Thanks very much jonezy

Ben

ahh, now it's producing a header error message...

Warning: Cannot modify header information - headers already sent by (output started at /home/soul-sca/public_html/vanilla/extensions/BreakFrames.php:15) in /home/soul-sca/public_html/vanilla/library/Vanilla.Session.class.php on line 27

jonezy

maybe try wrapping the if statement around it.

if (@$Head) { }

omfg

465446543217

Ben

for some reason, just re-uploading the file worked as well the problem seems to be solved, thanks everyone

jonezy

you are welcome ben.