Vanilla 1 is no longer supported or maintained. If you need a copy, you can get it here.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

Quality of Code: Too many notices?

For instance, the return value of DiscussionManager::GetDiscussionById is inconsistently tested. Maybe it should return a 'dummy' discussion object, but existing uses should be checked.

I do not know of other possible lines causing notices, but do you think it should be corrected?

Comments

  • MarkMark Vanilla Staff
    Depending on your version of PHP and how you have it configured, it could cause notices to appear. In our development we had no notices at launch with all error reporting turned on.
This discussion has been closed.