Bug with email reminders when BASE_URL uses https

redjar

The forum I have set up is using SSL. When BASE_URL uses a value starting with https (ie. https://forums.example.com), the role change and password change emails have a malformed URL.

For example, when the BASE_URL is set to https://forums.example.com, the url in the password change email looks like this:
https://forums.example.com/https://forums.example.com/people.php?PostBackAction=PasswordResetForm&u=1&k=6b7119c65b1fyd7e5989227e98e7dge9

it should be:
https://forums.example.com/people.php?PostBackAction=PasswordResetForm&u=1&k=6b7119c65b1fyd7e5989227e98e7dge9

When I change the BASE_URL back to "http", the emails contain correct URL's. Any simple fix for this? (I'm running Vanilla 1.0.3)

Stash

Although I know nothing on the subject, that looks like a core bug to me...

WallPhone

Yep, sure is.

Go to library/framework/functions.php and change line 84 from:
if (strpos($PathToConcatenate, 'http://') !== false) return $PathToConcatenate;

To:
if ( (strpos($PathToConcatenate, 'http://') !== false) && (strpos($PathToConcatenate, 'https://') !== false) ) return $PathToConcatenate;

Stash

Groovy - will this make it into 1.0.4?

WallPhone

It probably will.

It must be too early--I can't determine if that should be an && or an ||.

redjar

Should be, "||":
if ( (strpos($PathToConcatenate, 'http://') !== false) || (strpos($PathToConcatenate, 'https://') !== false) ) return $PathToConcatenate;

And the actual file is: library/Framework/Framework.Functions.php

Thanks for you help Dave, all is well now.

WallPhone

lol ::feels much better now that /me has had his coffee::