CalculateNumberOfPages() way too complicated

sirlancelot

library/Framework/Framework.Functions.php @ line 118

function CalculateNumberOfPages($ItemCount, $ItemsPerPage) {
    $PageCount = ceil($ItemCount/$ItemsPerPage);
    return ForceInt($PageCount, 1);
}

I know it's only executed once per request, but inefficiency is my pet peeve. Even if it's just replacing 13 lines with 2.

Minisweeper

how is this done at the moment? doesnt it have to take whispers etc into account or is that done to find itemcount?

sirlancelot

The parameters this function is fed are determined by the respective controller, check out the source: Framework.Functions.php. Functions are generally in alphabetical order.