HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

Please use $Sender instead of &$Sender in event handlers.

ToddTodd Chief Product Officer Vanilla Staff
When declaring an event handler there are a lot of instances where the $Sender parameter is declared as a reference. This is a bad practice and will break plugins in future versions of Vanilla.

So for example, do this:
public function Base_GetAppSettingsMenuItems_Handler($Sender) {
...
}
instead of this:
public function Base_GetAppSettingsMenuItems_Handler(&$Sender) {
...
}
This has been a Vanilla service announcement.

Comments

  • Interesting... Will do.

    There was an error rendering this rich post.

Sign In or Register to comment.