Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

Enable, Disable... and... Remove?

edited January 2010 in Vanilla 2.0 - 2.8
Ok, so I've been playing with the code base for a bit.

I noticed that the 'CssThemes' plugin cannot be disabled due to its database table (actually it is its content) not being cleaned up.

So, I am proposing to add another action to the Applications and Plugins (and possibly Themes, but I haven't gone through that bit yet), 'Remove'.

And add two more class methods, so the 'action' to 'method' mapping looks like:

Enable action -> Setup()
Disable action -> OnDisable()
Remove action -> CleanUp()

I *really* hope this is something that you core developers would like to see, as I have already started working on it.

Any thoughts?

P.S. It's 6:30AM here, I'm off to get some sleep. If all things go well, I will commit the changes to my Github fork and send you guys a pull request.

Comments

Sign In or Register to comment.