HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.
Options
Addons page - Strange filter behavior
A couple of days ago I uploaded my first Vanilla1 extension to the Addons page.
(Edit Buttons - http://vanillaforums.org/addon/492/edit-buttons)
When I view the default Addons page, I see my extension listed. If I deselect "Vanilla 2" I see a filtered list of all the Vanilla 1 extensions, but mine vanishes. If I deselect BOTH Vanilla 1 & Vanilla 2, my extension reappears.
It looks to me like my (Vanilla 1) extension only appears if the Vanilla 1 & 2 filter selectors are BOTH on or BOTH off.
Did I screw up something when I added my extension or is the sort page acting funny?
Thanks,
Ken
(Edit Buttons - http://vanillaforums.org/addon/492/edit-buttons)
When I view the default Addons page, I see my extension listed. If I deselect "Vanilla 2" I see a filtered list of all the Vanilla 1 extensions, but mine vanishes. If I deselect BOTH Vanilla 1 & Vanilla 2, my extension reappears.
It looks to me like my (Vanilla 1) extension only appears if the Vanilla 1 & 2 filter selectors are BOTH on or BOTH off.
IF( (van1 && van2 == 0) || (van1 && van2 ==1) ) display (ken's extensions); :-)Did I screw up something when I added my extension or is the sort page acting funny?
Thanks,
Ken
Tagged:
0
Comments
We recently open-sourced the addons site so that people like you could help us with bugs like this. You can get the latest copy of it on GitHub:
http://github.com/lussumo/VanillaAddons
And that bug in particular is going to be located somewhere around here:
http://github.com/lussumo/VanillaAddons/blob/master/controllers/addon.php#L341
I spent a few minutes looking at the code. It's a bit over my head, but looks good to me.
The sorting seems to work for some addons but not others which makes me think there is an issue with the individual database entries of the addons. It's as if the "Version" field is missing (or in the wrong format) in the db.
The odd behavior seems to occur with recently added extensions (like JQE WYSIWYG editor, AutoLogon, dance feet style, etc). Older addons are ok. So, my theory is that something has changed with the database entries of older vs. newer addons.
That's about as far as I am able to investigate.
Should I submit a Bug Report to the Issue Tracker?
I went to the IssueTracker page on GitHub. When I tried to open a new issue, I got a log-in page. My user/pass on this forum doesn't seem to work and when I click the sign up button, I see a page for starting my own collaborative account. I don't think that's what I want.
How do I get on GitHub so I can submit my bug?