Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

AddModule Bug

edited December 2009 in Vanilla 2.0 - 2.8
When writing module found a bug in adding modules.
For example, consider the DiscussionsController and the method Index.
When you add the module with
$this->AddModule( 'ModuleName')
module will render immediately, because there is line
$this->AddAsset ($ AssetTarget, $ Module->ToString (), $ Module->Name ());
in class Gdn_Controller method AddModule.
Because of this the result of the withdrawal will vary depending on where in the Index method you would call
$this->AddModule( 'ModuleName') 
especially if you are in a module using an array $Data.

I change line to
$this->AddAsset ($ AssetTarget, $ Module, $ Module->Name ());
*without ToString();


  • Options
    LincLinc Detroit Admin
    Hey Alaris, thanks for the heads up. Do you have a GitHub account to help us track issues?
  • Options
    Yes, I have GitHub account with same nickname "Alaris".
    I can help you, just say what should I do.
  • Options
    LincLinc Detroit Admin
    Create a new issue for this. If you also want to go ahead and make the change and send a pull request to Mark (lussumo) I'm sure it'd be appreciated.
Sign In or Register to comment.