URLS that begin with "https://" are treated as relative paths instead of absolute paths

tazz_ben

URLS that start with https:// are treated as relative paths, this results in urls to the RSS feed and any other resource having either an added "/" or if in a subfolder "/subfolder/" pre-pended to the URL.

Is there a known fix for this.

Linc

I think the issue is in /library/core/functions.general.php around line 265:

if (substr($Destination, 0, 7) == 'http://') {

Should be:

if (substr($Destination, 0, 7) == 'http://' || substr($Destination, 0, 8) == 'https://') {

Linc

Filed issue: https://github.com/vanillaforums/Garden/issues/issue/621

Pushed fix: https://github.com/lincolnwebs/Garden/commit/8db56bd86886232c338c329675172929d8e986be

tazz_ben

That seems to have fixed all of the issues except the gravatars, it does this to them:

/forum/uploads/https://secure.gra....

I assume somewhere in the code for the photo it is specifically looking for www.gravatar.com

Linc

These should remedy it and other https user photo issues: https://github.com/lincolnwebs/Garden/commit/ea39e5c4448b1e029362321ba1adfd005ec60ed3

tazz_ben

Thanks, but that doesn't resolve the issue, the gravatars are still going to:

https://www.wbpsystems.com/forum/uploads/https://secure.gravatar.com/navatar.php...

tazz_ben

The issue is line 255 in functions.render.php needs to be replaced with:

if(strtolower(substr($User->Photo, 0, 7)) == 'http://' || strtolower(substr($User->Photo, 0, 8)) == 'https://'){
$PhotoUrl = $User->Photo;
}else{
$PhotoUrl = 'uploads/'.ChangeBasename($User->Photo, 'n%s');
}

Linc

My bad, here it is: https://github.com/lincolnwebs/Garden/commit/2d3b761a9bab8b4468828167ffb4c414e62d5342

Linc

@tazz_ben Fixes are in 2.0.14 which was just released. http://vanillaforums.org/discussion/13567/vanilla-2.0.14-released

tazz_ben

Hi Lincoln -

All of them that were outlined or just the one in this thread? (ie. Issue with gravatar, https issue with any link, AND the https issues related to photos)

Linc

It includes all 3 changes I've linked to in this discussion which addresses all the ones I was aware of.

tazz_ben

Lincoln -

I just downloaded .14, the issue with gravatars (in the plug in itself is not fixed):

$User->Photo = 'http://www.gravatar.com/avatar.php?'
.'gravatar_id='.md5(strtolower($Object->$Email))
.'&default='.urlencode(Asset(Gdn::Config('Plugins.Gravatar.DefaultAvatar', 'plugins/Gravatar/default.gif'), TRUE))
.'&size='.Gdn::Config('Garden.Thumbnail.Width', 40);

You have to switch to https://secure.gravatar.com when on https otherwise you get security warnings all over the place. This is what I was talking about in:

http://vanillaforums.org/discussion/13535/fix-to-gravatar-plugin-for-ssl/#Item_2

Linc

Ah, I didn't get that far down the issue list on this go-around, sorry about that. I'll get a patch in for the next one.