HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

Code review request: Gdn_Format::Url regex

LincLinc Detroit Admin

I refactored the Url method, which is pretty core to the system. I found a lot of problems in it, especially weirdly over-expressive regex and a lot of duplicated code. If anyone who feels good about regex wants to have a look to make sure I didn't commit a grievous error I'd appreciate it. I'm especially interested in testing for my rewritten $UnicodeSupport test.

https://github.com/vanillaforums/Garden/commit/f7f348b419b6a3600d00ac9d66bc279f469db99e

Sign In or Register to comment.