Howdy, Stranger!

It looks like you're new here. If you want to get involved, click one of these buttons!

Try Vanilla Forums Cloud product
Vanilla 2.6 is here! It includes security fixes and requires PHP 7.0. We have therefore ALSO released Vanilla 2.5.2 with security patches if you are still on PHP 5.6 to give you additional time to upgrade.

Code review request: Gdn_Format::Url regex

LincLinc Director of DevelopmentDetroit Vanilla Staff
edited December 2012 in Development

I refactored the Url method, which is pretty core to the system. I found a lot of problems in it, especially weirdly over-expressive regex and a lot of duplicated code. If anyone who feels good about regex wants to have a look to make sure I didn't commit a grievous error I'd appreciate it. I'm especially interested in testing for my rewritten $UnicodeSupport test.

https://github.com/vanillaforums/Garden/commit/f7f348b419b6a3600d00ac9d66bc279f469db99e

Sign In or Register to comment.