Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.
Options

Why keep the SiteMenu with duplicated functionality in MeBox & Column?

The MeBox and content of the Column in the 2.1 default theme offer the exact same functionality (except maybe {custom_menu}), and I was wondering if there is any particular reason for that duplication.

Does it have to do with having full site functionality without javascript (in case a visitor uses a browser not capable of javascript or has it disabled)?

I think having the same functionality available at two different locations on a website is unnecessary and confusing for visitors, which is why I'd like to keep it simple. My plan is to completely remove the SiteMenu bar as I just don't really see the point in having it around.

Comments

  • Options
    hgtonighthgtonight ∞ · New Moderator

    Thankfully, Vanilla offers complete theming support allowing you to remove it. :D

    Welcome to the community!

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • Options

    @hgtonight said:
    Thankfully, Vanilla offers complete theming support allowing you to remove it. :D

    I know :)

    I was asking for the reason behind that duplication, someone must have thought it serves a purpose. I am digging my way through the available documentation, it's quite an awesome project, I'd call it "next generation forum".

    Theming is pretty much laid-out straight, although I'm just getting into CSS again after quite some time, and not all comes as easy as it used to...

  • Options
    hgtonighthgtonight ∞ · New Moderator

    The MeModule does requires javascript to function.

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • Options

    Indeed it may not be such a bad idea to keep the SiteMenu after all, still unsure though. One one hand I don't like multiple elements doing the same, on the other hand the site should be as compatible for all visitors as possible.

  • Options
    hgtonighthgtonight ∞ · New Moderator

    If you really want to make this "streamlined," you could add the MeModule and remove the site menu via JS. This way, users without JS get still get full functionality, and users with JS don't have the extra menu.

    This would require an extra response from the server though (to load the MeModule). To get around this, you could remove just the site menu via JS. This is the route I would take, if I were so inclined.

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • Options

    @hgtonight said:
    If you really want to make this "streamlined," you could add the MeModule and remove the site menu via JS. This way, users without JS get still get full functionality, and users with JS don't have the extra menu. This would require an extra response from the server though (to load the MeModule). To get around this, you could remove just the site menu via JS. This is the route I would take, if I were so inclined.

    A very interesting idea! Although I wouldn't want to remove the MeModule, as it provides shortcuts not provided by the SiteMenu.

    You wouldn't have such a JS snippet at hands, would you? :)

    I'll have to look into it later, this is definitely the way to go.

  • Options
    hgtonighthgtonight ∞ · New Moderator

    This worked for me on Baseline+ and Bittersweet on Vanilla 2.1b1

    jQuery(document).ready(function($) {
      $('ul.SiteMenu').remove();
    });
    

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • Options

    @hgtonight

    Wonderful! Where is the best place to put that code?

  • Options
    hgtonighthgtonight ∞ · New Moderator

    I like to add JS that is theme specific to my theme hooks file.

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • Options

    @hgtonight said:
    I like to add JS that is theme specific to my theme hooks file.

    There is so much to learn about Vanilla! Not having the insight (yet), do I have to put that JS snippet in a separate file and call it as

    public function Base_Render_Before($Sender) {
        $Sender->AddJsFile('custom.js');
      }
    

    or can I insert the snippet somehow directly into the theme hooks file?

    Sorry for being annoying, I am just beginning to understand how this all fits together. Vanilla & the Garden Framework is an amazing piece of software.

  • Options
    hgtonighthgtonight ∞ · New Moderator

    You want to keep your js in an external file. The sample I linked will search your theme folder for custom.js and link it in the header of every page.

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • Options

    It's working, very nice indeed :)

Sign In or Register to comment.