Comment section is hiding the footer

ahmedaladdin

Hi,

We have a small issue that the Comment section is hiding the footer! We investigate and no luck . This occurred after some CSS changes. The default.master.php file was left untouched.

Please refer to the screenshot below

hgtonight

What version of Vanilla are you running?

What theme are you using?

What modifications to the CSS did you make?

Since this is almost certainly a CSS issue, it is impossible to guess without knowing this information and/or having a link to the website in question.

@vrijvlinder eagerly awaits your reply!

ahmedaladdin

Vanilla 2.0.18.4

Custom theme based on vanilla's default theme

forum.strukts.com

Thanks @vrijvlinder and @hgtonight in advance

hgtonight

I really like the overall aesthetic of your site

How is your footlinks div being inserted?

ahmedaladdin

Thank you

In the default.master.php file which is located inside the custom theme folder.

I will extract the code and post it here

hgtonight

Ah, well you said in your first post that you didn't touch the master template file, so I was assuming you used something like pockets.

I await your upload/paste of the default.master.php file.

P.S. If you are having trouble posting it, I suggest using a service like pastebin.com and just linking it here.

ahmedaladdin

@hgtonight said:
Ah, well you said in your first post that you didn't touch the master template file, so I was assuming you used something like pockets.

I await your upload/paste of the default.master.php file.

P.S. If you are having trouble posting it, I suggest using a service like pastebin.com and just linking it here.

Yeah, thats correct. I didnt touch the default.master.php file during the CSS changes!

I tried to paste the links in pckets, but I found the same result

The default.master.php file is here: http://itrnsfr.com/it-download/?96da2f590cd7246bbde0051047b0d6f7/a51ee8f363d8178467c7677e48d1f3e0/3LkJk

hgtonight

I would suggest moving your footlinks div to right after the ?> after the line $this->RenderAsset('Foot');. This will put all the links in the properly styled footer element you have.

Once you get this sorted, I noticed a few other things that are probably causing performance issues.

ahmedaladdin

See now

ahmedaladdin

I moved the footer links from under ?> to be after $this->RenderAsset('Foot'); but the page loaded with Error line Parse....

Then moved down a little bit and no luck. However, I really appreciate that you registered and investigate the problem inside the default.master.php file @hgtonight

hgtonight

Be sure to clear the /cache folder of it's files (leave the folders) to see any updates to your master views.

peregrine

I moved the footer links from under ?> to be after $this->RenderAsset('Foot'); but the page loaded with Error line Parse....

Then moved down a little bit and no luck

parse error - means you typed something wrong when you made the changes.

suggest you do what you said you would do and post your modified snippet of default.master.tpl

vrijvlinder

Please Make me a an account called TestUser with password test so I can view it then after you can delete the account.

it is hard to diagnose the problem unless I see it live.

ahmedaladdin

Done and login details sent to you

vrijvlinder

Ok thanks for that I saw what you need and here is the fix replace these blocks of code in your custom.css

    .footlinks {
    font-size: 14px;
    text-align: center;
    font-weight: bold;
    color:#ccc;
    margin-top: 10px;
    position: relative;
    top: 290px;
    padding-bottom: 50px;
    }
    .MessageForm, .Tabs, .Headings {
    background: none repeat scroll 0 0 #fbfbfb;
    border-bottom: 1px solid #fbfbfb;
    display: block;
    margin: 0;
    padding: 5px 8px;
    position: relative;
    height: 55px;
    top: 100px;
    }
.MessageForm .Tabs {
padding: 0;
border: 0;
background: none;
text-align: left;
position: relative;
top: -5px;
}

vrijvlinder

You actually have an html error in the master that is why the positioning is off.

You need to add the bottom menu like this below the first Foot div, Here I created a new div called FootMenu yours is called footlinks, but this is an example of how I aded a foot menu. Please notice where everything is.You can use this model to create your php links just replace the names and path

 <div id="Foot">
<div id="FootMenu">

            <?php
                  $Session = Gdn::Session();
                    if ($this->Menu) {

             $this->Menu->AddLink('Home', T('Home'), '/');
                     $this->Menu->AddLink('Activity', T('Activity'), '/activity');
                     $this->Menu->AddLink('Categories', T('Categories'), 'categories/all');
                     $this->Menu->AddLink('Discussions', T('Discussions'), '/discussions');
                     $this->Menu->AddLink('Mobile View', T('Mobile View'), 'profile/mobile');
                     $this->Menu->AddLink('Privacy', T('Privacy'), 'plugin/PrivacyNotice');

                        echo $this->Menu->ToString();
                    }
                ?>

         </div><br><div class="Search"><p><?php
                    $Form = Gdn::Factory('Form');
                    $Form->InputPrefix = '';
                    echo 
                        $Form->Open(array('action' => Url('/search'), 'method' => 'get')),
                        $Form->TextBox('Search'),
                        $Form->Button('Go', array('Name' => '')),
                        $Form->Close();
                ?></p></div>
<?php $this->RenderAsset('Foot'); 

echo Wrap(Anchor(T('Powered By Vanilla'), C('Garden.VanillaUrl'),array('target' => '_blank')), 'div');  

?>  
      </div>
   </div>