No this would be placed in the theme master, it is javascript . It is only a cosmetic potential fix. I have not tested this but if you do test it add it like this to the foot of the default.master.php after the last /div
Thanks @vrijvlinder. Should've asked this in my original post / question, but is there a way for ReplyTo to acknowledge the space as + in replies? This would obviously save me from having to hack files or add fixes to change usernames.
So right now, when I click reply, user "John F" gets "Reply to @John+F", but only recognizes the "@John" part (underlines and links it) and ignores the +F. If I could add something to ReplyTo's php so it sees John+F as one username, wouldn't that be an alternative fix?
Another thing I noticed. jsConnect is creating the member's username based off whatever is defined in their user profile (in my case, WordPress) in a field labeled "Display name publicly as" ... usually it's their first name, last initial.
If I can get jsConnect to create the member's username based off the username they created when signing up to my membership program (in WP, under the Username field when clicking through User > Edit User) and NOT the "Display name publicly as" field, this issue would be solved.
Any suggestions which files / lines to edit within the plugin, just to test and see?
There should be a quick easy way but I have not found one that works yet, My advice Is add a message asking the members to change it in their profile. People should understand that space between names causes problems even in a url if the file name has spaces it will add %20 or something to fill the gap.
If they don't want that to happen they should not use space or use another character to separate.
@dbcuadro said:
is there a way for ReplyTo to acknowledge the space as + in replies?
Standard user profile links are in the form of /profile/{user_id}/{username}, for example mine on this forum is /profile/38268/hgtonight. Mention profile links are in the form of /profile/{username}, mine would be /profile/hgtonight.
Mentions are formatted in class.format.php on line 950+. Try replacing the code block there with this one:
It worked for me on a stock 2.0.18.8 install, but your mileage may vary. I also got it working on 2.1 so I may submit this as a patch IF I can get some testing on it on multiple server environments.
I tried copying class.format.php into my theme's folder (under the same [my theme folder]/library/core/ folder structure) but it didn't work. Technically it should, right?
I tried copying class.format.php into my theme's folder (under the same [my theme folder]/library/core/ folder structure) but it didn't work. Technically it should, right?
Themes can't supersede core files. You should be able to load it in your bootstrap file. I can't do any testing right now to verify it though.
I'm using Vanilla jsConnect Version 1.0.3b, Vanilla Version 2.0.18.10. Users are being passed from Wordpress and usernames are formatted as Firstname Lastname, which of course isn't working for the @mention logic. I was able to fix this issue like this:
In file class.jsconnect.plugin.php, line 217. Replace as follows:
Comments
No this would be placed in the theme master, it is javascript . It is only a cosmetic potential fix. I have not tested this but if you do test it add it like this to the foot of the default.master.php after the last /div
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌
This one is supposed to remove a space in between the words
http://stackoverflow.com/questions/4932898/jquery-replace-spaces-in-word
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌
Thanks @vrijvlinder. Should've asked this in my original post / question, but is there a way for ReplyTo to acknowledge the space as + in replies? This would obviously save me from having to hack files or add fixes to change usernames.
So right now, when I click reply, user "John F" gets "Reply to @John+F", but only recognizes the "@John" part (underlines and links it) and ignores the +F. If I could add something to ReplyTo's php so it sees John+F as one username, wouldn't that be an alternative fix?
Another thing I noticed. jsConnect is creating the member's username based off whatever is defined in their user profile (in my case, WordPress) in a field labeled "Display name publicly as" ... usually it's their first name, last initial.
If I can get jsConnect to create the member's username based off the username they created when signing up to my membership program (in WP, under the Username field when clicking through User > Edit User) and NOT the "Display name publicly as" field, this issue would be solved.
Any suggestions which files / lines to edit within the plugin, just to test and see?
I think you been pointed as far as anyone who hasn't opened up the tool to dissect it could take you.
call it a category 3.
Vanilla Wiki, Tastes Great! 31,000 viewers can't be wrong. || Plugin Development Explained
There should be a quick easy way but I have not found one that works yet, My advice Is add a message asking the members to change it in their profile. People should understand that space between names causes problems even in a url if the file name has spaces it will add %20 or something to fill the gap.
If they don't want that to happen they should not use space or use another character to separate.
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌
Standard user profile links are in the form of
/profile/{user_id}/{username}
, for example mine on this forum is/profile/38268/hgtonight
. Mention profile links are in the form of/profile/{username}
, mine would be/profile/hgtonight
.Mentions are formatted in
class.format.php
on line 950+. Try replacing the code block there with this one:It worked for me on a stock 2.0.18.8 install, but your mileage may vary. I also got it working on 2.1 so I may submit this as a patch IF I can get some testing on it on multiple server environments.
Search first
Check out the Documentation! We are always looking for new content and pull requests.
Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.
@hgtonight worked for me. Thanks!
I tried copying class.format.php into my theme's folder (under the same [my theme folder]/library/core/ folder structure) but it didn't work. Technically it should, right?
Themes can't supersede core files. You should be able to load it in your bootstrap file. I can't do any testing right now to verify it though.
Search first
Check out the Documentation! We are always looking for new content and pull requests.
Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.
I'm using Vanilla jsConnect Version 1.0.3b, Vanilla Version 2.0.18.10. Users are being passed from Wordpress and usernames are formatted as Firstname Lastname, which of course isn't working for the @mention logic. I was able to fix this issue like this:
In file class.jsconnect.plugin.php, line 217. Replace as follows:
// $Form->SetFormValue('Name', GetValue('name', $JsData));
$noSpaceName = preg_replace('/\s+/', '', GetValue('name', $JsData));
$Form->SetFormValue('Name', $noSpaceName);
Any reason this won't work? It seems to be working fine.