Mention feature is not working for urdu user names.

UrduAnswer

Hi,
mention feature is working nice for English user names but it is not working for Urdu user names, any one knows about this issue?

R_J

You might want to look at those two pull requests:
https://github.com/vanillaforums/Garden/pull/1653/files
https://github.com/vanillaforums/Garden/pull/1654/files

The mention function has some inconveniences. Although you can specify allowed usernames in config with $Configuration['Garden']['User']['ValidationRegex'] = '\d\w_' and this will be used in the function that validates usernames, it is not used for the mentioning function. Neither is the setting $Configuration['Garden']['User']['ValidationLength'] = array(3,20)used.
In fact, there are two functions dealing with mentions and both use slightly different regex!
'/(^|[\s,\.>])@(\w{1,50})\b/i' https://github.com/vanillaforums/Garden/blob/2.1/library/core/class.format.php
'/(?:^|[\s,\.>])@(\w{3,20})\b/i' https://github.com/vanillaforums/Garden/blob/2.1/library/core/functions.general.php
My aim with the above pull requests was to align the config settings with the functions. The change will not help if your users are allowed to use spaces in usernames but you could add a regex to your config which should allow Urdu characters to be validated and also be handled correctly in mentions

hgtonight

What version number of Vanilla are you running?

The current mention system uses a regex to find and replace the @name with a link to the associated profile. It looks for word characterd , \w, after @ signs.

The \w character only matches latin characters as far as I know.

You would have to update the regex to also match urdu characters.

UrduAnswer

@hgtonight said:
What version number of Vanilla are you running?

The current mention system uses a regex to find and replace the @name with a link to the associated profile. It looks for word characterd , \w, after @ signs.

The \w character only matches latin characters as far as I know.

You would have to update the regex to also match urdu characters.

verion is 2-0-18-8
How i can update regex?

hgtonight

Mentions are formatted through the Mentions($Mixed) method in /library/core/class.format.php.

You can override the mentions in an upgrade safe way by creating a MentionsFormatter class that has a FormatMentions method and including it in your conf.

UrduAnswer

@hgtonight said:
Mentions are formatted through the Mentions($Mixed) method in /library/core/class.format.php.

You can override the mentions in an upgrade safe way by creating a MentionsFormatter class that has a FormatMentions method and including it in your conf.

can you give an example to make it easy....i have very little knowledge about php.

hgtonight

I can't think of an example.

I can think of 3 easy solutions:

• Disable mentions
• Don't allow usernames with Urdu characters in them
• Pay somebody to fix your issues

I can also think of the solution I would employ:

• Create a MentionsFormatter class with a FormatMentions method to override the the Mentions($Mixed) method in /library/core/class.format.php.
• Test
• Iterate

I am not trying to blow you off. I don't have any experience with Urdu characters.

R_J

You might want to look at those two pull requests:
https://github.com/vanillaforums/Garden/pull/1653/files
https://github.com/vanillaforums/Garden/pull/1654/files

The mention function has some inconveniences. Although you can specify allowed usernames in config with $Configuration['Garden']['User']['ValidationRegex'] = '\d\w_' and this will be used in the function that validates usernames, it is not used for the mentioning function. Neither is the setting $Configuration['Garden']['User']['ValidationLength'] = array(3,20)used.
In fact, there are two functions dealing with mentions and both use slightly different regex!
'/(^|[\s,\.>])@(\w{1,50})\b/i' https://github.com/vanillaforums/Garden/blob/2.1/library/core/class.format.php
'/(?:^|[\s,\.>])@(\w{3,20})\b/i' https://github.com/vanillaforums/Garden/blob/2.1/library/core/functions.general.php
My aim with the above pull requests was to align the config settings with the functions. The change will not help if your users are allowed to use spaces in usernames but you could add a regex to your config which should allow Urdu characters to be validated and also be handled correctly in mentions