Vanilla 2.1 release candidate

Linc

Important

1. This release is for testing purposes, not production use.
2. Get your testing in ASAP - I don't plan a second RC unless there is significant trouble with this one.
3. Open bugs against the beta on GitHub by prefixing the title with: [2.1]
4. Upgrading from the 2.0 branch involves an extra step. Instructions in the 2.1 beta 3 discussion

Download Here

Release Notes (since beta 3)

• 2014-04-21 Profiles: Fix unread discussions to reflect viewer, closes #1846
• 2014-04-21 Import: Verify Poll table exists
• 2013-09-19 Place the activity & wall forms into a .FormWrapper-Condensed.
• 2013-09-19 Remove the activity form specific styles. Fix vertical alignment when reaction sprites are next to inputs.
• 2013-09-19 Remove the .TextBoxWrapper fix and just use box-sizing: border-box.
• 2013-07-17 Change the alignment of the activity form so that it's not a special case for stuff like the button bar.
• 2014-04-20 Edit function decho
• 2014-04-18 Move .Hidden to end of style.css, closes #1838
• 2014-04-18 Merge error
• 2014-04-18 Fix validation to use validateregex, closes #1837
• 2014-04-18 EditCategory fix: use exception, not form error
• 2014-04-18 Filter empty integers for MySQL strict mode
• 2014-04-18 Structure tweaks for MySQL strict mode
• 2014-03-14 ignore NetBeans stuff
• 2014-04-16 Improvements to comment embedding
• 2014-04-18 Fix dupe Dashboard in MeModule, closes #1834
• 2014-04-18 Rm errant popin; closes #1833, #1843, #1841, #1842, #1836, #1853
• 2014-04-17 Autodetect Internet on install for using CDNs
• 2014-04-04 Show Friendly Error Message for Non-Numeric Category ID
• 2014-04-04 Show Friendly Error Message for Non-Numeric Category ID

peregrine

Is http://vanillaforums.org/discussions/unread

meaning "unread discussions listing".

supported in 2.1 rc1

• if so it has a bug with permissions and custom categories permissions that have discussions that should be unviewable by member role. The Titles of "unviewable" discussions is not filtered out. This may have been filed before, I couldn't find it and si I posted a new issue on github.

the other question - does the "unread" option in menu put more stress on server and slow down performance, does it scale well with servers with lots of simulteaneous users using this option.

chanh

Nice, it is getting closer to a release! Thanks for the effort!

Linc

@peregrine We should either support it or remove it, so yes, that would be a legit bug to file.

I imagine it would add some strain to very large sites by virtue of the fact that it doesn't allow discussion pagination caching via memcached. If you're not big enough to worry about memcached, you're not likely to notice.

Linc

One thing I'd like folks to look closer at in 2.1 RC1: Markdown support, including its interaction with ButtonBar, Quotes, FileUpload, etc.

jackjitsu

OOOOOOOooooooo so this means a prod release may be coming soon? /frothing-at-mouth

peregrine

since you are using jQuery v1.10.2 on vanillaforums.org.

when is the likelihood, that you will be changing it from 1.7.2. in a vanilla 2.1 release.

it appears 2.1RC1 is still using 1.7.2

chanh

The strict mode code is not working.

chanh

After I clean up the cache, delete the database, make sure the permission on the cache folder is in order and it install just fine.

My bad! Sorry about that.

Linc

@peregrine said:
when is the likelihood, that you will be changing it from 1.7.2. in a vanilla 2.1 release.

Very unlikely since 1) I'd basically have to take it back to beta for a change that big and 2) I really don't feel like cherry-picking those commits in when it'll happen naturally for 2.3 and 3) 2.3 is less far off on the horizon than you probably think.

peregrine

One thing I'd like folks to look closer at in 2.1 RC1: Markdown support, including its interaction with ButtonBar, Quotes, FileUpload, etc.

made some mods to FileUpload plugin ver 1.8.2 to work with 2.1 RC1 here.

http://vanillaforums.org/discussion/26644/a-fix-to-make-fileupload-version-1-8-2-to-work-in-vanilla-2-1-backport

fr3em1nd

nice release! are the core plugins updated as well?

Linc

@fr3em1nd Yes, from 2.0.18 to 2.1 you'd be hard-pressed to find anything that wasn't updated in the core repo.

peregrine

what about making FileUpload, Quotes, WhosOnline and a couple more home-grown plugins part of the core for each version, so some of the more popular plugins don't have to be sought out on github.

In other words the three or 4 most popular plugins in the add-ons section developed or adopted by vanilla.

peregrine

@fr3em1nd said:
nice release! are the core plugins updated as well?

you can see the core plugins for 2.1 here:

https://github.com/vanillaforums/Garden/tree/2.1/plugins

Linc

It's an interesting idea. Quotes, in my mind, is the foremost candidate. The others are a bit more complicated due to possible deprecation by other addons.

My overall thought is: I think 2.3 is where you're going to see core addons shake out better. I'm championing some changes that I don't think will be ready for a 2.1 release, and I'm really anxious to get 2.1 out the door without rocking the boat too hard.

R_J

I find it quite confusing that the branches of the Addons are different from the Garden repo. Maybe you could think about that, too, and help finding the corresponding version of addons

Dr_Sommer

YES!!! Great newz...

Can't wait for the new HTML Editor...
my people are still killing me cause of the lacks in CLEditor and Smileys etc.

Chapeau to the developers...

Linc

Last call for issues, folks!

UnderDog

Besides that issue with the SQL statement (see http://vanillaforums.org/discussion/comment/206209/#Comment_206209) (no bug report yet) no issues for me ...

How are the themes looking? How are the major addons doing? Is upgrading easy?

peregrine

here's a few issues. Not sure if it is due to flaw in plugin programming or flaw in core, or lack of knowledge I haven't filed a bug.

this part works correctly:

when you add a plugin, the active arrow focuses on the link clicked on the side menu in the dashboard.
the plugin added the link via addlink method to the sidepanel in dashboard.

---

However, when you addlink to the main menu via plugin

i.e. in Main Navgation Menu: Discussions, Activity, NewLink.

the New link added never gets a class of "Selected" when it is selected.

the NewLink added to the menu doesn't sort with configuration array that sorts other menu items, nor does a Select Class get added when the "New Link" is clicked.

$Configuration['Garden']['Menu']['Sort'] = array(Activity, 'Discussions', 'Conversations', 'Applicants', 'Dashboard');

Does the config statement above work with .tpl themes in 2.1rc1

Linc

Selectively answering the last part: yes, sort works regardless of template language. That happens in the framework before the view is rendered.

peregrine

@Lincoln said:
Selectively answering the last part: yes, sort works regardless of template language. That happens in the framework before the view is rendered.

sort via config statement: ?

$Configuration['Garden']['Menu']['Sort'] = array(Activity, 'Discussions', 'Conversations', 'Applicants', 'Dashboard');

doesn't seem to work for me., can someone show me a screenshot of a sorted menu with a default.master.tpl theme.

and the the config statement that worked sorting the menu displayed in your screenshot.

just to humor me.

apparently no one can prove it .

vrijvlinder

I Can corroborate that menu sort does not work on a mobile tpl or regular tpl. It works on all my php themes including mobile, but does not work on tpl template .

$Configuration['Garden']['Menu']['Sort'] = array('New Discussion', 'Dashboard', 'Gallery', 'Games', 'Activity', 'Conversations', 'Discussions', 'Categories', 'Questions', 'Applicants', 'User', 'EditProfile','Inbox','Home', 'Mobile View', 'VChat', 'SignIn', 'SignOut', 'Contact','Gallery','Games', 'Privacy');

I suspect it is because the menu is not the menu it is called banner ?

peregrine

thank you for corroborating.

and in a php based theme the config statement . will not sort naviagation menu items added via addlink,

nor will it add the select class to those Navigation Menu items that were added via addlink in a plugin, it will however add the Active class to menu items in dashboard panel

vrijvlinder

Yes they will sort as long as you add the link in the statement where you want it to show.

I just did an experiment, I replaced all the Banner in the embed friendly tpl and css for Menu and I got to sort a couple of them.The sign out link and the dashboard link .

I think this must have something to do with it. The order that they appear in the theme hooks is not how it shows, so something is getting sorted

these are the links I added in the themehooks

$Sender->Menu->AddLink('Categories', T('Categories'), '/categories/all');
$Sender->Menu->AddLink('Home', Img('themes/TinyEmbedFriendly/design/images/hicon.png', array('title' => T('Home'))), 'http://www.yoursite.com',  array('class' => 'Button'));
$Sender->Menu->AddLink('Games', Img('themes/TinyEmbedFriendly/design/images/smile.png', array('title' => T('Games'))), 'plugin/Games',  array('class' => 'Button'));
$Sender->Menu->AddLink('NewDiscussion', Img('themes/TinyEmbedFriendly/design/images/new.png', array('title' => T('Start New Discussion'))), 'post/discussion',  array('class' => 'Button'));        
$photo = UserPhoto(Gdn::Session()->User);
   $Sender->Menu->AddLink('User',  $photo,  '/profile/{UserID}/{Username}',array('Garden.SignIn.Allow'), array('class' => 'UserNotifications'));
}

They do not appear in this order however...yea something is funky with the sort

peregrine

are you on a tangent - or are you specifically talking about the config statement, which I am talking about, that doesn't appear to sort things in a tpl file nor does it sort things added via addlink in a plugin, nor does it add a Select class when item is selected if the item is not one of the standard home dashboard activity, etc.

vrijvlinder

Specifically the config statement. Yes and yes. You can also test your theory by using the categories drop down plugin which also does not work on tpl it adds the categories in no particular order.

I do recall removing the links added by plugins to the menu and coding them by hand in my master php or the theme hooks. Because of this problem. Which seems to apply to sorting modules as well....

peregrine

I do recall removing the links added by plugins to the menu and coding them by hand in my master php or the theme hooks. Because of this problem

yes there are workarounds. doesn't change the issue at hand though.

Linc

Try $Configuration['Modules']['Vanilla']['Menu']?

peregrine

@Lincoln

Try $Configuration['Modules']['Vanilla']['Menu']?

had no impact on ordering for my test in vanilla 2.1rc1

I don't want to de-rail the whole discussion, just thought I would post some of the issues related to menu selection and ordering in tpl themes and with plugin additions of addlinks, if it is something you guys think should work.

should I file on github?