Error generated by BetterNotifications when trying to send private message

DoyceT

Vanilla 2.1
BetterNotifications 2.0.0

With debug on in config.php, when hitting Send Message to reply to a private message, I get the following:

Fatal error: Cannot use object of type stdClass as array in /home5/nilaedu/public_html/onlinecampus/plugins/BetterNotifications/class.betternotifications.plugin.php on line 48

Any suggestions welcome.

DoyceT

Update: The reply is ACTUALLY posting. It just don't look like it is until I refresh the page, so I end up replying with the same post a half-dozen times.

hgtonight

Either cast the object to array before access or access the member directly instead.

Adding the following line to line 47 of class.betternotifications.plugin.php should quash that error:

$Activity = (array)$Activity;

DoyceT

Will try that asap.

DoyceT

Worked perfectly. Thanks!

jamesinc

Sorry it took me so long to get to this... ironically perhaps I can get some help here. I don't do a lot of PHP work, and it seems to me like explicitly casting $Activity to an array will then render the following check redundant:

if ( is_array($Activity) ) {
   // Access by key
   $Activity['ActivityType']
} else {
   // Access by property
   $Activity->ActivityType
}

Are you saying if I do an explicit cast to an array I can just drop the if/else and treat it as an array at all times? If so I will update the plugin.

Also I'm confused as to why is_array is generating a fatal error. Isn't the whole point of the function to check if the provided object is an array?

peregrine

haven't looked at plugin - but you could do something like this

if $Activity can be an object or an array.

 if ( (array) $Activity !== $Activity ) {   
 // Access by property   
 $x = $Activity->ActivityType;
} else {
 // Access by key
$x = $Activity['ActivityType'];
}

after looking at code why not change to

 $BookmarkComment = ($Activity->ActivityType == 'Comment' || $Activity->ActivityType == 'BookmarkComment');


preg_match( "/comment\/([0-9]+)/", $Activity->Route, $RouteMatches );

Bleistivt

or just use val('ActivityType', $Activity)

jamesinc

Thanks guys, @Bleistivt‌ that val() function seems to have done the trick. I take it this is a global function in Vanilla?

peregrine

@jamesinc said: I take it this is a global function in Vanilla?

yes

https://github.com/vanilla/vanilla/blob/master/library/core/functions.compatibility.php#L201