I tested other plugins which were reported to not disable, they did not have it all the other aspects were ok. Name etc. I added it and it disabled. May be a coincidence . Maybe it is unnecessary but I have seen it in several plugins which made me think it was useful function to have.
In the interest of getting everything discussed so far included while it's all still fresh, I've removed the extra <?php as well as the code at the end designed to help it disable cleanly (it disables successfully without it).
Newest version uploaded to the addon page as v 0.2.2.
another feature should anyone feel up to it that would be cool (I think)
is to have an additional dropdown
Text Size Change
default
large text
small text
that changes font size in discussion titles and the body of discussion (at the least).
could probably incorporate selection and add a smalltext.css, largetext.css) if the user selects either one.
if default is selected do nothing.
would help older people with ailing eyes and vision impaired people.
something generic that would work with at least bittersweet theme and default themes that increases font by a percentage (perhaps instead of a number) and decreases fon-size (for people with good eyes who want to see more titles of discussions on the discussion page (without scrolling excessivley).
I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.
I might play. probably need to do some importants if adding to css. changing on web inspector doesn't follow inheritnace of pre-existing css because you've changed the pre-existing css .
I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.
You only need to define Setup and Disable functions when you are implementing the plugin interface. Since you are extending the plugin class (which already defines the required interface functions), you don't need to override them.
Comments
I can tell you right now what it is ...
don't close the first php tag and don't open new ones unless it is to echo something
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌
Okay, I made peregrine's suggested changes to file names and it uploaded.
http://vanillaforums.org/addon/customhomepage-plugin-0.2
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌
Also incorporated vrij's cleanup of the php tags. Icons and screenshot added.
why are you including this
public function OnDisable() {
return TRUE;
}
I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.
I told him to do so ... was it wrong? that makes sure it disables no?
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌
.
I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.
I tested other plugins which were reported to not disable, they did not have it all the other aspects were ok. Name etc. I added it and it disabled. May be a coincidence . Maybe it is unnecessary but I have seen it in several plugins which made me think it was useful function to have.
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌
Maybe this one is more useful
public function OnDisable() { $this->_EmptyCache(); }
or this one to get rid of the settings too
Mostly this appears in theme hooks look at bittersweet theme hooks
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌
@vrijvlinder
remove it and test if you can disable the theme .
in a plugin it doesn't matter either way probably.
vs.
nothing at all.
other than there is less code.
@DoyceT
only other improvement (nitpicks) for next update time is to remove the extra <?php
e.g.
and to format it so it is indented properly. you can use netbeans for formatting (a free ide).
nice job. probably not worth the trouble to change unless you add more features.
I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.
In the interest of getting everything discussed so far included while it's all still fresh, I've removed the extra <?php as well as the code at the end designed to help it disable cleanly (it disables successfully without it).
Newest version uploaded to the addon page as v 0.2.2.
another feature should anyone feel up to it that would be cool (I think)
is to have an additional dropdown
Text Size Change
that changes font size in discussion titles and the body of discussion (at the least).
could probably incorporate selection and add a smalltext.css, largetext.css) if the user selects either one.
if default is selected do nothing.
would help older people with ailing eyes and vision impaired people.
something generic that would work with at least bittersweet theme and default themes that increases font by a percentage (perhaps instead of a number) and decreases fon-size (for people with good eyes who want to see more titles of discussions on the discussion page (without scrolling excessivley).
I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.
just make a style sheet with this in it
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌
@vrijvlinder
did you try it? - does it look ok on your themes. when you add it to the bottom of your css.
which is essentially what an additional css file would do.
I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.
I tried it here on this forum by adding it to the body css using web inspector. It makes everything 120% larger and looks great !!
The one other example with all the elements I use with VFonts.
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌
I might play. probably need to do some importants if adding to css. changing on web inspector doesn't follow inheritnace of pre-existing css because you've changed the pre-existing css .
I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.
You only need to define Setup and Disable functions when you are implementing the plugin interface. Since you are extending the plugin class (which already defines the required interface functions), you don't need to override them.
Search first
Check out the Documentation! We are always looking for new content and pull requests.
Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.
yes using !important is important to make this work for real . It works with the VFonts plugin.
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌
just to clarify for me and others @hgtonight
Is this what you mean
I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.
I guess theme hooks Implement IPlugin and that is why they contain OnDisable True
You can also see this in old plugins which implement instead of extend so it is not a matter of theme hooks or plugin but how it is used ?
Interesting..
❌ ✊ ♥. ¸. ••. ¸♥¸. ••. ¸♥ ✊ ❌