Great theme.. But

This discussion is related to the MinusBaseline addon.

Love the theme, great job. Really focuses on the content. Removes all the unnecessary things from the screen at a clicks notice.

But, I'd love to see a control panel for the accent color at the top. Otherwise, great job.

Comments

  • vrijvlindervrijvlinder Papillon-Sauvage MVP

    What is the purpose of the control panel for the header color ? that has go to be the easiest thing to change in the custom.css file.

    peregrine
  • Thanks for trying my theme!

    Like @vrijvlinder‌ said, it's really only a single color and I used the standard Vanilla blue.

    I made no changes to the #Head background color, but if you want to change the color of the slide button, thats on line 102.
    Or just search for #38ABE3

    My themes: pure | minusbaseline - My plugins: CSSedit | HTMLedit | InfiniteScroll | BirthdayModule | [all] - PM me about customizations

    • Vanilla APP » Learn more «
    • iOS & Android App for Vanilla - White label app for your forum
    peregrine
  • I like this theme a lot, good job!

    the edit link (in discussions, after clicking the gear icon) seems not to be working for me

  • @ceeray What device and browser are you experiencing this on?

    My themes: pure | minusbaseline - My plugins: CSSedit | HTMLedit | InfiniteScroll | BirthdayModule | [all] - PM me about customizations

    • Vanilla APP » Learn more «
    • iOS & Android App for Vanilla - White label app for your forum
    hgtonightceeray
  • ceerayceeray New
    edited December 2014

    android 4.4.4

    chrome 31.0.2171.93
    and
    lightning 3.2.0.1a

    I have not tried Firefox yet, but will later when I get on Wi-Fi

    hgtonight
  • BleistivtBleistivt MVP
    edited December 2014

    I wish I could reproduce this :/

    For me it's working on Android 5.0.1, Chrome 39 and Firefox 34.0.1 It was also working with a few chrome versions before on Android 4.4.

    Can you access the console or do you have a test site you can link me to?

    My themes: pure | minusbaseline - My plugins: CSSedit | HTMLedit | InfiniteScroll | BirthdayModule | [all] - PM me about customizations

    • Vanilla APP » Learn more «
    • iOS & Android App for Vanilla - White label app for your forum
    hgtonightceeray
  • firebox 34 didn't work for me :(

    I tried changing the non mobile theme, didn't help.. then I changed the mobile theme to vanilla mobile and the edit button worked there so...

    I have firebug on a laptop

  • peregrineperegrine MVP
    edited December 2014

    not sure if this is the case for your issue but...

    if the edit buttons don't work, it may be because js is broken due to a faulty plugin or something js that was added that is broken.

    if something works in mobile but not in non-mobile, it may be because you have js that is loading and broken in non-mobile that doesn't get loaded in mobile.

    the best way to find out is to look in the web console to see if you have js errors.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • peregrineperegrine MVP
    edited December 2014

    I noticed the options when clicked move outside the browser window when testing with emulation. It is possible the absolute vs relative positioning may be the issue, if it is not js.


    before shadowdare deleted his own message he suggested something regarding positioning.

    p.s. when a moderator posts and decides to deletes post and someone clicks on a reaction on the deleted message you get

    Column 'UserID' cannot be null|Gdn_Database|Query|insert GDN_UserTag (RecordType, RecordID, TagID, UserID, DateInserted, Total) values (:RecordType, :RecordID, :TagID, :UserID, :DateInserted, :Total) on duplicate key update Total = Total + :Total2

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

    Shadowdare
  • Yes, the positioning is off when viewing it on the desktop but that doesn't matter because it's a mobile only theme. This probably cannot be emulated correctly:

    (This is a standard select menu)

    @ceeray It's probably a javascript error, do you see any errors in the firebug console?
    If you could access the mobile Chrome console that would be even better:
    https://developer.chrome.com/devtools/docs/remote-debugging

    (or just send me a link and I will take a look)

    My themes: pure | minusbaseline - My plugins: CSSedit | HTMLedit | InfiniteScroll | BirthdayModule | [all] - PM me about customizations

    • Vanilla APP » Learn more «
    • iOS & Android App for Vanilla - White label app for your forum
    peregrine
  • ShadowdareShadowdare Moderator
    edited December 2014

    @peregrine, I deleted my post (see below) since I misread the problem as @ceeray said the icon can be clicked, but the edit button just doesn't work. Maybe @Linc can look into that error with the reactions.


    @ceeray, sometimes I can't click on the fly-out options menu cog icon because it would be layered under another element, but still visible. I originally posted this CSS rule before I deleted my post just now:

    .Item .Options {
        position: relative;
        z-index: 500;
    }
    

    You can give this a try, but I misread the problem, and will just leave this here in case it's useful.


    Edit: since the menu looks like it uses the phone's modal according to Bleistivt's image, it sounds like a JS issue to me like Peregrine said if this is the case.

    Add Pages to Vanilla with the Basic Pages app

    peregrine
  • For everyone experiencing this issue: I have uploaded a new version of the theme with a fix.

    (It was an incompatibility caused by the different jQuery versions of 2.1 master)
    Thanks to @ceeray for giving me a test account on the site

    My themes: pure | minusbaseline - My plugins: CSSedit | HTMLedit | InfiniteScroll | BirthdayModule | [all] - PM me about customizations

    • Vanilla APP » Learn more «
    • iOS & Android App for Vanilla - White label app for your forum
    hgtonightperegrinevrijvlinderceeray
  • works great, thanks again!

Sign In or Register to comment.