Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.
Options

Separate "embed theme" setting

2»

Comments

  • Options

    Embedfriendly in my mind, also means js in the theme will work when embedded. As you can see some plugins won't work correctly if embedded, because the js breaks down when embedded, so if js in a themehook breaks down when embedded, it is not Embedfriendly. Some absolute positioning and other things may not work the same when embedded.

    So, it is more than window size.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • Options
    vrijvlindervrijvlinder Papillon-Sauvage MVP
    edited November 2014

    Yes true, which is why embedded forums kind of suck because of the non predictable nature
    Also I prefer to use php based master on themes I make because they seem to respond better even when embedded. I have none of the js issues that creep up.

  • Options

    Well but with my additions it's possible to mark all themes that are "embed friendly" with "IsEmbed" true.
    That way a developer can still decide to pick the same theme for both the embed version as the outside version.

    I still think this is a good addition to the code base and I still propose a pull :)

Sign In or Register to comment.