Cannot Delete PM's on Mobile Devices

Simeon_Griggs

Problem noticed on iOS devices but perhaps Android too. When the confirmation popup appears 'Are you sure you want to do that', the Cancel button works but the Okay button does not.

Adrian

I've seen that happen too, but I have not been able to replicate it in a meaningful way to create an issue in Github. It's quite random. Sometimes, it's a loading issue and if you do it again it works. Maybe someone has luck in replicating it consistently, and can open it as an issue on Github. Please make sure to note if it's the standard mobile theme and the version of Vanilla you are using.

Simeon_Griggs

I'm getting it on all themes, all of the time. So are my users.

Is it possible to remove the confirmation in the mean time, by changing a setting perhaps?

Simeon_Griggs

@Adrian Can we entirely remove the confirmation from deleting messages?

Adrian

I am sure it's possible, but I would not recommend it. It's always good to give a second chance, especially considering how fingers can make accidents on phones. What version of Vanilla are you using? Have you updated to the latest version? Have you tried to see if any plugins are causing a conflict?

Adrian

Wait, I just realized you are talking about Private conversations and not comments/discussions. You are not able to delete PMs in the standrad mobile theme. You can leave/delete a conversation on your desktop.

So you may have some customization I am thinking to delete on your mobile. My original comment was related to deletion of comments & discussions. I recommend upgrading and trying to see if there is a plugin conflict before attempting to remove confirmation.

Simeon_Griggs

Thanks,

Using the latest version, even with plugins disabled. Just can't press the Okay button on mobile devices. I have some users that only ever use the mobile version.

hgtonight

@Simeon_Griggs said:
Thanks,

Using the latest version, even with plugins disabled. Just can't press the Okay button on mobile devices. I have some users that only ever use the mobile version.

Can you post a screenshot?

Simeon_Griggs

Screen shot: http://m.imgur.com/mw2H3gp

Simeon_Griggs

@hgtonight Any ideas?

Simeon_Griggs

Can be fixed in CSS:

http://vanillaforums.org/discussion/comment/230714/#Comment_230714

Simeon_Griggs

@Simeon_Griggs said:
Can be fixed in CSS:

http://vanillaforums.org/discussion/comment/230714/#Comment_230714

...but not on the Bootstrap theme it seems.

Simeon_Griggs

So the problem appears to be that /js/library/jquery.popup.js auto-focuses the Okay button, rendering it unpressable in iOS (in some themes)

I changed line 45 from:

$('#'+settings.popupId+' .Okay').focus().click(function() {

to

$('#'+settings.popupId+' .Okay').click(function() {

Sorry if I have not reported/fixed this problem properly ... I understand this change will be overwritten if I upgrade the forum. But hoping someone here more knowledgable might suggest a more permanent fix!

vrijvlinder

@Simeon_Griggs said:
a more permanent fix!

You could add the css for focus into your mobile theme's css

http://www.w3schools.com/cssref/sel_focus.asp

Simeon_Griggs

Yep, tried that. Added -webkit-appearance: none to the element :focus but for some reason couldn't get it to work in the Bootstrap theme.

The more obvious fix, I would've thought, would be to remove the focus state from the button. Unless there's a compelling reason for making it focused by default.

vrijvlinder

@Simeon_Griggs said:
Yep, tried that. Added -webkit-appearance: none to the element :focus but for some reason couldn't get it to work in the Bootstrap theme.

Sometimes when rules don't comply, you need to add !important to them , or find the rule for focus in the default theme and edit it. There is not one theme I have encountered that I can't make it my bitch so to speak.....

Simeon_Griggs

Trust me, I tried every variation of wrangling the CSS that I knew. Unless I missed something stupidly obvious (and that's a real possibility), I couldn't get it to work with edits to the CSS.

vrijvlinder

-webkit webkit only works with webkit browsers like Safari and chrome. You need to use just focus or hover or active, depending on what it is that is causing the issue.