Blog Documentation Book a Demo
Vanilla 1 is no longer supported or maintained. If you need a copy, you can get it here.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

New Add-on: Edit in place [beta]

WallPhoneWallPhone
edited January 2007 in Vanilla 1.0 Help
Edit In Place is now an extension.

Allows users to click on any post that they have editing permissions on, and the post is replaced via Ajax inline with the comment form.

Its currently beta, so go out and find those bugs!
«1

Comments

  • MinisweeperMinisweeper New
    Link to anywhere it's working? :D
  • JazzmanJazzman
    edited August 2006
    Awesome! Installed it on my site :) But it only works in Firefox. IE gives javascript error.

    IE page render:
    <script type="text/javascript">EditInPlace.makeEditable( { id: 'CommentBody_1"></a>

    Firefox page render:
    <script type="text/javascript">EditInPlace.makeEditable( { id: 'CommentBody_56', save_url: 'extensions\EditInPlace\eip.php?CommentID=56' } ); </script>
  • WallPhoneWallPhone
    edited August 2006
    You can test it on edacio.us/forum/ username & password: guest

    For some odd reason, my server is running a bit slow.

    I have a new version up that fixes that javascript error. IE still doesn't have the hover hightlight that indicates editable.
  • ToivoToivo New
    The editing is quick but there should be option to cancel it when I dont want to change anything. Click - edit - click - cancel.
  • WallPhoneWallPhone
    edited August 2006
    There is a 'click to cancel and go back' link to the right of the save button...

    It reloads the page, but alas, it came with the form.

    I will see if I can script it.... uggh, now no hightlighting is working on my site.
  • ToivoToivo New
    it's hard to explain how it should act. it was some wiki (have forgotten which one of these) that acted more .... smoothly.
  • gigingergiginger New
    I like the way it works but when you said Edit in Place I thought you literally meant that. I wasn't expecting it to pop down into the comment box. Stll a good extension. I look forward to seeing this 100% finished :)
  • WallPhoneWallPhone
    edited August 2006
    Giginger: How else could something be edited in its place? It should be putting a comment form in the same space the post occupied, be it top of the discussion, middle or bottom.

    Toivo: It ts still partially finished, allthough functional. When done you will be able to edit and view the update completely without loading a new page.
  • a_ja_j
    edited August 2006
    http://labs.mininova.org/todolist2/ maybe something like this? server's down, but source @ google cache http://64.233.161.104/search?q=cache:lmESpqiuDakJ:www.codepost.org/view/120+ajax+todo+list+tutorial&hl=en&gl=us&ct=clnk&cd=1&client=firefox-a edit: nm, when I tried the demo earlier I was hitting the "edit" button, not clicking on the text. looks good! on a side note, not getting the hilighting on mouseover in firefox (latest) os x. installing it tonight, thanks!
  • WallPhoneWallPhone
    That Todo list is sweet!

    I will clean up and style the form a bit to get it appearing to work more smoothly.

    Highlighting broke somewhere on my server, but the add-on download is still OK (at least for Firefox)
  • gigingergiginger New
    Giginger: How else could something be edited in its place? It should be putting a comment form in the same space the post occupied, be it top of the discussion, middle or bottom.

    I was thinking of something along the same lines as flickr. When you edit the title of a picture it's done without loading it into another box. Does that make sense?
  • WallPhoneWallPhone
    Sure... but then the user wouldn't be able to change the formatter. (my usual reason for editing)

    Here is an idea: What about just replacing with a plain text box and a save/cancel button, but also have an advanced edit button that loads the comment form? Too much complexity?
  • DinoboffDinoboff
    you could just leave the edit button
  • gigingergiginger New
    I see your point WallPhone. How about having it so that if a user clicks on the post they edit it in place literally? Then if they want to do more editing then they click the edit button and it all pops down to the comment box as you have it now?

    Did I say that clearly enough?
  • WallPhoneWallPhone
    Clear as crystal! One thing to note, I originally did have an literal edit in place, but it edited the literal contents of CommentBody, <br /> tags, long form hyperlinks and all. I could do a quick javascript parse to replace the BRs with carriage returns, but I hate programming in JS. Any volunteers?
  • gigingergiginger New
    Cool, glad I made sense :)

    I'd love to volunteer to help but, as is probably evident, I can't code a bean.
  • gasfacegasface
    the DL is corrupt
  • WallPhoneWallPhone
    Should be fixed now
  • gasfacegasface
    Parse error: syntax error, unexpected T_ISSET, expecting '(' xxx/extensions/EditInPlace/eip.php on line 4
  • WallPhoneWallPhone
    edited August 2006
    Hmm... Sorry about that, some untested code made its way in there.

    Add parens around the condition:if ( isset($_GET['CommentID']) ) { // Get the comment form

    EDIT: Should be fixed on add-ons.
This discussion has been closed.