Blog Documentation Book a Demo
Vanilla 1 is no longer supported or maintained. If you need a copy, you can get it here.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

New Add-on: Edit in place [beta]

2»

Comments

  • erissivaerissiva
    I'm not exactly sure what this supposed to be doing. I installed it, but have not noticed any change at all in the board's functionality. How is it supposed to work?
  • WallPhoneWallPhone
    There are some useability problems that are all on the TODO. If you are running IE, it doesn't highlight where you need to click to edit.

    Try clicking in the comment body, the words you want to edit.

    this is a screenshot of how it should work, notice the post above and after the one being edited:

    image
  • STE7130STE7130
    can it be, that the REWRITE-ENGINE is not supported?

    The plugin don´t work in my vanilla, when i turn of the Rewrite it works
  • DinoboffDinoboff
    Are you using these rules: http://lussumo.com/community/discussion/2803/search-engine-friendly-urls-breaks-extension-manager/#Item_10
  • WallPhoneWallPhone
    Ooh, good find. Adding to the TODO.
  • trunkadelictrunkadelic
    edited August 2006
    Does it work with 1.0.1? I still get that syntax error, did you update the file in the meantime? Thanks for the great work by the way, this is my favorite extension so far and I'd like to see it done. edit: I just saw that fix for eip.php, now it works swell.
  • WallPhoneWallPhone
    The demo is running on 1.0.1, no new problems have been found.

    jeez... I can't believe I forgot to re-upload the fix. Addons now has what is running on my server now.
  • trunkadelictrunkadelic
    Great. By the way, have you ever considered the possibility to minimize the extension, like in some other forums? People would want to use edit-in-place mostly when they want to make a quick edit (typos etc.) but they'll most probably click on the regular edit if they want to change the whole post. So, my idea is - when you click on the post you want to quick-edit, you don't get a full editing comment form like it is now, but you only get the comment box and "save" & "cancel" buttons instead. Just a thought.
  • erissivaerissiva
    Wallphone - I seriously hate to sound like a complete idiot, but I have no idea why this is not working at all on my install.
    I am using 1.0.1, and have installed the newest version of this extension. The source of my page looks like this:

    So...It it's loading...but it isn't working. Also having trouble with SmoothPageJump - but it might be unrelated. Thought I'd mention it since they both use the prototype library.
  • WallPhoneWallPhone
    hmmm... Just below the comments list and above the 'add comments' form, there should be a bunch of scripts that are needed to activate editing for the comments.

    For example:<div class="PageInfo"> <p>1 to 12 of 12</p> <ol class="PageList PageListEmpty"> <li>&nbsp;</li> </ol> </div> </div><script type="text/javascript">EditInPlace.makeEditable( { id: 'CommentBody_92', save_url: 'extensions\EditInPlace\eip.php?CommentID=92' } ); EditInPlace.makeEditable( { id: 'CommentBody_93', save_url: 'extensions\EditInPlace\eip.php?CommentID=93' } ); EditInPlace.makeEditable( { id: 'CommentBody_94', save_url: 'extensions\EditInPlace\eip.php?CommentID=94' } );
    This should only appear if there are some editable comments.

    I've never tested with SmoothPageJump--and won't be able to until possibly after the weekend-- Does editing work if you disable the others?
  • erissivaerissiva
    Actually, those javascripts are not appearing on the page at all. There are definitely editable comments considering I''m logged in as the admin.

    I disabled those other extensions with no change. The javascripts still don't show up as embedded in the page.
  • WallPhoneWallPhone
    Well, I re-downloaded and compared and the add-ons version is identical to what is running on my server currently. A bit baffled. What version of PHP & Vanilla? Was it upgraded from 1.0 to 1.01?

    Another thing to try is to put echo count($CommentIDs); about line 20 in default.php. (should be a todo block of comments) This should return the number of comments that can be edited.
  • erissivaerissiva
    PHP Version: 5.1.2
    Vanlla Version: 1.0.1. Yes, I upgraded.

    I added in that bit of code and got a '000' above the title of the post. However, I definitely can edit all posts in the thread.
    Weird.
  • WallPhoneWallPhone
    edited September 2006
    OK, it appears to be friendly URLs is the cause. To fix, edit line 16 $CommentIDs = returnSubstrings($CommentList, '?CommentID=', '">'. $CommentGrid->Context->Dictionary['edit']);Should instead read: $CommentIDs = returnSubstrings($CommentList, 'post/', '/">'. $CommentGrid->Context->Dictionary['edit']);

    This was written in php 4.4.4, so there may be another bug there.
  • erissivaerissiva
    Wall-Phone - That fix works perfectly. Thanks.
    However, I noticed that when you hit the "cancel and go back" just in case you edit by accident - it goes back to the index instead of just canceling the edit. Perhaps there should be something like "cancel edit" (although I realize it is much easier to just to pull the comments panel into the post)?
  • WallPhoneWallPhone
    That link is a little wierd--it doesn't work at all in IE. It will be replaced.
  • chrischris
    any news on this? looking forward to a friendly url, errr, friendly version! :)
  • StashStash ✭
    Indeedy :)
  • WallPhoneWallPhone
    I guess its time to brush up on my Ajax skills...
  • StashStash ✭
    I noticed there's some "Edit in place" options for jQuery, such as jEditable. Might be worth looking at that? Seems to be compatible with quite a few of the text formatters that have been created for Vanilla.
This discussion has been closed.