Missing Activity Log: "[user] changed his profile picture"

Answers

• Options

  peregrine MVP

  January 2014 edited January 2014 Answer ✓

  problem is with the current code $OldPhoto will actually always be equal to $Photo because the check is made too late. Therefore an activity record will never be written.

  Yes I believe you found a bug in

  /applications/dashboard/models/usermodel.php

  to make it add to activity and check photo correctly...
  you could change the code form

                   $this->SQL->Put($this->Name, $Fields, array($this->PrimaryKey => $UserID));
  
                     // Record activity if the person changed his/her photo.
                     $Photo = ArrayValue('Photo', $FormPostValues);
                     if ($Photo !== FALSE) {
                        if (GetValue('CheckExisting', $Settings)) {
                           $User = $this->GetID($UserID);
                           $OldPhoto = GetValue('Photo', $User);
                        }
  
  
  
  to
  
  
                    if (GetValue('CheckExisting', $Settings)) {
                           $OldPhoto = GetValue('Photo', $User);
                        }
  
                     $this->SQL->Put($this->Name, $Fields, array($this->PrimaryKey => $UserID));
  
                     // Record activity if the person changed his/her photo.
                     $Photo = ArrayValue('Photo', $FormPostValues);
  
                     if ($Photo !== FALSE) {
                        if (GetValue('CheckExisting', $Settings)) {
                        $User = $this->GetID($UserID);
                        //   $OldPhoto = GetValue('Photo', $User);
                    }
  

  I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  2
• Options

  Aolee Hobbyist & Coder ✭✭

  January 2014

  that's perfect! Thanks Peregrine!

  1
• Options

  peregrine MVP

  January 2014 edited January 2014 Answer ✓

  @Aolee said:
  that's perfect! Thanks Peregrine!

  no prob. glad it worked. nice find.

  I put your "issue" on github with above solution.

  https://github.com/vanillaforums/Garden/issues/1774

  I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  1