HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.
Please upgrade here. These earlier versions are no longer being updated and have security issues.

Working on version 2.5?

This discussion is related to the Yet Another Gamification Application addon.
2

Comments

  • // Yaga
    $Configuration['Yaga']['Version'] = 'Undefined';

    i had this ^, now i have added your code instead of this, and still the same..

  • pioc34pioc34 Pézenas ✭✭

    Yaga application isn't enabled in your forum. You can test to add

    $Configuration['EnabledApplications']['Yaga'] = 'yaga';
    // Yaga
    $Configuration['Yaga']['Version'] = '1.1';
    $Configuration['Yaga']['Reactions']['Enabled'] = '1';
    $Configuration['Yaga']['Badges']['Enabled'] = '1';
    $Configuration['Yaga']['Ranks']['Enabled'] = '';
    $Configuration['Yaga']['MenuLinks']['Show'] = '1';
    $Configuration['Yaga']['LeaderBoard']['Enabled'] = '1';
    $Configuration['Yaga']['LeaderBoard']['Limit'] = '10';

    to your conf file

  • @pioc34 said:
    I forked yaga and updated code to work with vanilla 2.5
    https://github.com/pioc92/Application-Yaga
    Test il if you want.

    Are the changes been incorporated in official app?

  • whu606whu606 I'm not a SuperHero; I just like wearing tights... MVP
    edited April 2018

    @Waqass

    The author of YAGA hasn't been active on here recently.

    I don't know if @R_J (who is now our resident non-staff code guru, imo) would have time to look at the fork and determine if the changes are 'Vanilla appropriate', but otherwise, if you want to use YAGA on 2.5 you may have to go with the fork, rather than the original version.

    And thanks to @pioc34 for taking the time to share their code.

  • R_JR_J Ex-Fanboy Munich Moderator

    @Waqass said:
    Are the changes been incorporated in official app?

    "Official" isn't quite right: YAGA by hgtonight is only a third party plugin and piocs fork is only another third party plugin. As such there is no reason not to go with the fork, as long as it is working for you

    @whu606 said:
    I don't know if @R_J (who is now our resident non-staff code guru, imo) would have time to look at the fork and determine if the changes are 'Vanilla appropriate'

    There are no major changes in there. Looking at the code didn't take much time =)

    @pioc34 said:
    I forked yaga and updated code to work with vanilla 2.5
    https://github.com/pioc92/Application-Yaga
    Test il if you want.

    I would recommend to make this 3 or 4 pull requests:
    1. Code cleanup: you have stripped out a lot of trailing spaces and replaced a deprecated function
    2. 2.5 compatibility: you have replaced all those AddSideMenu with setHighlightRoute (and maybe Gdn_Autoloader::start(); is part of that, too?)
    3. You've worked on the french translation

    Although @hgtonight isn't active here any more, I bet he would reply to pull requests if they are simple enough to be checked quickly.


    data66
  • Testing on my local dev which I just upgraded to 2.6. This works great so far! Thank you @pioc34 for this update. :) I'll continue to test and report any issues but so far it's all working fine for me.

    pioc34
  • @data66 said:
    Testing on my local dev which I just upgraded to 2.6. This works great so far! Thank you @pioc34 for this update. :) I'll continue to test and report any issues but so far it's all working fine for me.

    I've upgraded to 2.6 & downloaded pico34's fork
    I'm getting a couple of errors:

    Declaration of BadgeModel::Delete($BadgeID) should be compatible with Gdn_Model::delete($where = Array, $options = Array)

    Declaration of BadgeModel::Get() should be compatible with Gdn_Model::get($orderFields = '', $orderDirection = 'asc', $limit = false, $pageNumber = false)

  • sparrowhawk66sparrowhawk66 Kraków New

    @data66 What changes did you make in your config or elsewhere to make it work in 2.6? I tried the original version in 2.6 – it worked, but crashed my admin panel, so I had to remove it. Was it because i hadn't put this in my config:
    $Configuration['Yaga']['Version'] = '1.1';
    $Configuration['Yaga']['Reactions']['Enabled'] = '1';
    $Configuration['Yaga']['Badges']['Enabled'] = '1';
    $Configuration['Yaga']['Ranks']['Enabled'] = '';
    $Configuration['Yaga']['MenuLinks']['Show'] = '1';
    $Configuration['Yaga']['LeaderBoard']['Enabled'] = '1';
    $Configuration['Yaga']['LeaderBoard']['Limit'] = '10';
    ?
    After that I tried the version of @pioc34 – it didn't work at all and crashed the site outright.
    At any rate I have the strict mode disabled.
    Interestingly, with Yaga enabled I could see the g+ icon when using the Bootstrap theme (otherwise invisible in this theme).

  • pioc34pioc34 Pézenas ✭✭

    @Pjeff it’s your error_reporting in php.ini, this errors are only php notices.

    R_J
  • pioc34pioc34 Pézenas ✭✭

    @sparrowhawk66 Do you use the original vanilla's thème?

  • sparrowhawk66sparrowhawk66 Kraków New

    @pioc34 said:
    @sparrowhawk66 Do you use the original vanilla's thème?

    No, I tried it with Bootstrap, Material2 and maybe yet another theme, but not perhaps vanilla's original theme.

  • sparrowhawk66sparrowhawk66 Kraków New

    Sort of working. Enabling Yaga.Ranks crashes site.

  • sparrowhawk66sparrowhawk66 Kraków New

    Oh no, it's only showing for the admin! What can I do?

  • whu606whu606 I'm not a SuperHero; I just like wearing tights... MVP

    Check permissions for members.

  • pioc34pioc34 Pézenas ✭✭

    I updated the fork because there was a javascript bug on the Gamification Side Menu. Try it! https://github.com/pioc92/Application-Yaga

  • sparrowhawk66sparrowhawk66 Kraków New

    @whu606 said:
    Check permissions for members.

    Yes, I have done that. It is displaying OK for logged-in users.

    @pioc34 Could you address crashing the panel when yaga.ranks.use enabled, too?

  • pioc34pioc34 Pézenas ✭✭

    I don’t use ranks but i will check it.

  • pioc34pioc34 Pézenas ✭✭

    I can't reproduce your bug. Could you set $Configuration['Debug'] = true; in your config.php file in conf folder and tell us the error message please?

  • sparrowhawk66sparrowhawk66 Kraków New

    @pioc34 said:
    I can't reproduce your bug. Could you set $Configuration['Debug'] = true; in your config.php file in conf folder and tell us the error message please?

    https://edu.cloud.webo.hosting/index.php/s/jaeLnDof5iY8izE

    The html file and debug-after_enabling_ranks are for ranks enabled

  • pioc34pioc34 Pézenas ✭✭

    look at this https://open.vanillaforums.com/discussion/36316/admin-panel-fatal-error

    i don't know why but your configuration file isn't ok.

    do you have
    // Yaga
    $Configuration['Yaga']['Version'] = '1.1';
    $Configuration['Yaga']['Reactions']['Enabled'] = '1';
    $Configuration['Yaga']['Badges']['Enabled'] = '1';
    $Configuration['Yaga']['Ranks']['Enabled'] = '1';
    $Configuration['Yaga']['MenuLinks']['Show'] = '1';
    $Configuration['Yaga']['LeaderBoard']['Enabled'] = '1';
    $Configuration['Yaga']['LeaderBoard']['Limit'] = '10';

    in your config.php file?

Sign In or Register to comment.