Users running a non-download version of Vanilla (pulled from github), on branch release/2019.016 or master from the last 2 weeks should upgrade to release/2019.017 or latest master for security reasons. Downloaded official open sources releases are not affected.
Please upgrade here. These earlier versions are no longer being updated and have security issues.

Code Sniffer showing violations in default applications with Vanilla Standards

We have configured code sniffer with Vanilla Standards to make sure our custom code will be as per Vanilla Standards but it is showing violations even in default applications files i.e conversation?

I think, Vanilla Standards ruleset has been customized to make sure, it only shows violations when the code is not as per Vanilla/Garden framework but it proving me wrong as it also showing some violations in existing files.

I am not complaining here but a bit curious to know this behaviour.

Kindly throw some light here.

Comments

  • R_JR_J Cheerleader & Troubleshooter Munich Moderator

    The coding style has changed a few years ago. Changes weren't applied for every aspect, only for some reasonable things. This is a discussion which covers a lot of the developers questions back then: https://open.vanillaforums.com/discussion/30014/beware-the-4-spacening-this-week-25-may

    For the rest of the coding standard violations that you find, Lincs last comment would be good: "Fix 'em as you find 'em in code you change."


  • LincLinc Director of Development Detroit Vanilla Staff

    The dev team is currently discussing how to best update our standards to both streamline them and get our default code sniffing to only report the more relevant issues that need to be resolved.

    rbrahmson
Sign In or Register to comment.